fix: graceful fallback for missing external MCCs#4
Merged
Conversation
BetterString.mcc and HotkeyString.mcc were hard runtime dependencies of the preferences editor (MCP). If either was absent, MUI_NewObject returned NULL and the NULL was passed as a MUI Child tag, crashing the system. - ostring(): try BetterStringObject first, fall back to StringObject - CreatePrefsGroup(): pre-create HotkeyString+snoop HGroup; fall back to built-in Keyadjust when HotkeyString.mcc is absent - InputClass: guard SimpleButton(Value) against NULL Value on <input type="button"> without a VALUE attribute - Refresh README with runtime requirements table and changelog
86b3687 to
ce7a163
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BetterString.mcc and HotkeyString.mcc were hard runtime dependencies of the preferences editor (MCP). If either was absent,
MUI_NewObjectreturned NULL and the NULL was passed as a MUIChildtag, crashing the system.Changes
ostring()— tryBetterStringObjectfirst, fall back to built-inStringObjecton failureCreatePrefsGroup()— pre-create the HotkeyString + snoop button HGroup outside the MUI tree; fall back to built-inKeyadjustwhenHotkeyString.mccis not installed. Snoop notification setup is guarded by aNULLcheck.InputClass.cpp— guardSimpleButton(Value)against NULLValueon<input type="button">without aVALUEattribute (matching the existing guard in theInput_Submitcase)README.mdwith runtime requirements table documenting all optional MCC dependencies and their fallback behavior, plus a changelog covering work since v12Audit findings (no fix needed)
InputClass.cpp/IsIndexClass.cpp— BetterStringObjectFLG_LayoutedskipTextAreaClass.cpp— TextEditorObjectSelectClass.cpp— CycleObjectScrollGroup.cpp— ScrollbarObject / RectangleObjectCreatePrefsGroup()— CacheSliderClass / GammaSliderClass