Skip to content

Update node version #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anishapant21 merged 4 commits into from
Mar 11, 2026
Merged

Update node version #148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4f21b64
Update node version
anishapant21 Mar 9, 2026
610d60f
Merge branch 'dev' into chore/upgrade-node-24
anishapant21 Mar 9, 2026
0983420
Add package lock
anishapant21 Mar 11, 2026
d77bb01
Update package lock
anishapant21 Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build-and-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ on:
workflow_dispatch:

env:
NODE_VERSION: '18'
NODE_VERSION: '24'
REGISTRY_URL: 'https://registry.npmjs.org'

jobs:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ on:
branches: [ main, dev ]

env:
NODE_VERSION: '18'
NODE_VERSION: '24'

jobs:
# Stage 1: Fast unit tests (fail fast)
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/prod.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
- name: Setup Node.js
uses: actions/setup-node@v4
with:
node-version: 18
node-version: 24

- name: Install dependencies
run: |
Expand Down
4 changes: 2 additions & 2 deletions MIGRATION.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ const providers = {

#### Old Dockerfile Pattern
```dockerfile
FROM node:18
FROM node:24
COPY src/ /app/src/
COPY package.json /app/
RUN npm install
Expand All @@ -168,7 +168,7 @@ CMD ["node", "src/server.js"]

#### New Dockerfile Pattern
```dockerfile
FROM node:18
FROM node:24
# Option 1: Use binary release
COPY ldap-gateway /usr/local/bin/
CMD ["ldap-gateway"]
Expand Down
2 changes: 1 addition & 1 deletion homebrew/ldap-gateway.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ class LdapGateway < Formula
sha256 "PLACEHOLDER_SHA256"
license "MIT"

depends_on "node@18"
depends_on "node@24"

def install
# Install all files to libexec
Expand Down
6 changes: 3 additions & 3 deletions nfpm/nfpm.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ homepage: "https://github.com/mieweb/LDAPServer"
license: "MIT"

depends:
- nodejs (>= 18.0.0)
- nodejs (>= 24.0.0)

provides:
- ldap-gateway
Expand Down Expand Up @@ -76,9 +76,9 @@ deb:
overrides:
deb:
depends:
- nodejs (>= 18.0.0)
- nodejs (>= 24.0.0)
- systemd
rpm:
depends:
- nodejs >= 18.0.0
- nodejs >= 24.0.0
- systemd
2 changes: 1 addition & 1 deletion npm/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"author": "MieWeb",
"license": "MIT",
"engines": {
"node": ">=18.0.0"
"node": ">=24.0.0"
},
"peerDependencies": {
"@ldapjs/controls": "git+https://github.com/mieweb/controls.git",
Expand Down
33 changes: 28 additions & 5 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@
"server"
],
"engines": {
"node": ">=18.0.0",
"npm": ">=9.0.0"
"node": ">=24.0.0",
"npm": ">=10.0.0"
},
"scripts": {
"build": "npm run build --workspaces",
Expand Down
4 changes: 2 additions & 2 deletions server/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
"name": "ldap-gateway-server",
"version": "1.0.0",
"engines": {
"node": ">=18.0.0",
"npm": ">=9.0.0"
"node": ">=24.0.0",
"npm": ">=10.0.0"
},
"main": "serverMain.js",
"bin": {
Expand Down
4 changes: 2 additions & 2 deletions server/test/e2e/Dockerfile.server
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM node:18-slim AS builder
FROM node:24-slim AS builder

WORKDIR /app

Expand Down Expand Up @@ -28,7 +28,7 @@ WORKDIR /app/server
RUN npm install --no-audit --no-fund
COPY server ./

FROM node:18-slim
FROM node:24-slim
COPY --from=builder /app /app
WORKDIR /app/server
EXPOSE 636
Expand Down
Loading