Open
Conversation
Member
|
@Geni-96 lets block time to discuss this. Not sure why we need this for RTC? Also, the code is got bloat in it. There should only be one uploader. |
horner
requested changes
Oct 12, 2025
Member
horner
left a comment
There was a problem hiding this comment.
This seems like code bloat where functions are recreated rather than being used. We want DRY lasagna not WET spaghetti.
| /** | ||
| * Delete a single chunk by its ID. | ||
| */ | ||
| async deleteChunkById(id) { |
Member
There was a problem hiding this comment.
this should be not be done again where there already is something.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation can read from a file in batches and once a batch upload is complete, it deletes them from db.
Updates:-