Skip to content

real time streaming directly from webrtc client#12

Open
Geni-96 wants to merge 1 commit intomainfrom
stream-to-ozwell
Open

real time streaming directly from webrtc client#12
Geni-96 wants to merge 1 commit intomainfrom
stream-to-ozwell

Conversation

@Geni-96
Copy link
Copy Markdown
Collaborator

@Geni-96 Geni-96 commented Jul 18, 2025

The current implementation can read from a file in batches and once a batch upload is complete, it deletes them from db.
Updates:-

  1. Read chunk by chunk from a readable stream(created from mediarecorder)
  2. Stream the chunks in the correct order to ozwell concurrently.
  3. Delete the individual chunk from db if ozwell confirms the chunk is received.
  4. Timer based retry logic for uploading and storing chunks in db.
  5. A message indicating that the call ended, so that we can close connections.

@Geni-96 Geni-96 requested a review from horner July 18, 2025 18:19
@horner
Copy link
Copy Markdown
Member

horner commented Oct 12, 2025

@Geni-96 lets block time to discuss this. Not sure why we need this for RTC? Also, the code is got bloat in it. There should only be one uploader.

Copy link
Copy Markdown
Member

@horner horner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like code bloat where functions are recreated rather than being used. We want DRY lasagna not WET spaghetti.

/**
* Delete a single chunk by its ID.
*/
async deleteChunkById(id) {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be not be done again where there already is something.

@horner horner added the wip label Oct 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants