Fixed HTTP Port Mapping - All HTTP requests work on Port 80#1
Merged
maxklema merged 2 commits intomieweb:mainfrom Jun 20, 2025
Merged
Fixed HTTP Port Mapping - All HTTP requests work on Port 80#1maxklema merged 2 commits intomieweb:mainfrom
maxklema merged 2 commits intomieweb:mainfrom
Conversation
Collaborator
|
Tested against multitimer-dashboard container and confirmed, one thing I will note is on some applications assigning port 80 to an app may require root privileges if ran on a different user, such as meteor. If the container specific HTTP port is no longer being used we will need to remove it from the port_map.js script as well at a future date. |
cmyers-mieweb
approved these changes
Jun 20, 2025
Collaborator
cmyers-mieweb
left a comment
cmyers-mieweb
left a comment
There was a problem hiding this comment.
Approving, but need to also review port_map.js http port assignment at a later date if it is now obsolete.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All container HTTP requests (ie. test-container.opensource.mieweb.com:80) are able to use port 80 instead of unique HTTP ports. Updated the nginx reverse proxy configuration file to proxy pass to $backend_ip:80 instead of $backend_ip:$backend_port. Updated all associated logging, too.