Merged
Conversation
… routes and views
…gery Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
cmyers-mieweb
approved these changes
Nov 7, 2025
Collaborator
cmyers-mieweb
left a comment
There was a problem hiding this comment.
Looks good, we can work on getting this merged next week.
runleveldev
added a commit
that referenced
this pull request
Nov 10, 2025
runleveldev
added a commit
that referenced
this pull request
Nov 10, 2025
fix proxmox username mismatch caused by #104
This was referenced Nov 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces major improvements to the data model, authentication middleware, and database schema for the LXC container management application. The changes include a migration to a normalized node model, enhanced uniqueness constraints, new authentication middleware, and the addition of several dependencies for session and flash message support.
Database Model and Migration Overhaul:
Added a new
Nodemodel and table, normalized container-to-node relationships by replacing the stringnodefield inContainerwith a foreign keynodeId, and migrated all relevant data and constraints. This includes new migrations for creating theNodestable, updatingContainers, and seeding and converting data appropriately. (create-a-container/migrations/20251104184238-add-node-field-to-containers.js,create-a-container/migrations/20251104193601-create-node.js,create-a-container/migrations/20251104193722-convert-container-node-to-node-id.js,create-a-container/models/node.js,create-a-container/models/container.js) [1] [2] [3] [4] [5] [6] [7]Enforced service uniqueness at the database level by adding unique indexes for HTTP services on
externalHostnameand for TCP/UDP services on the tuple(type, externalPort). (create-a-container/migrations/20251104160710-add-service-uniqueness-constraints.js,create-a-container/models/service.js) [1] [2]Extended the
Nodemodel and table to store Proxmox API token credentials (tokenId,secret). (create-a-container/migrations/20251105145958-add-api-token-to-nodes.js,create-a-container/models/node.js) [1] [2]Authentication and Session Management:
Added new authentication middleware to distinguish between API and browser requests, returning appropriate responses or redirects, and introduced an admin-only middleware. (
create-a-container/middlewares/index.js)Added a migration for a persistent
Sessionstable, supporting session storage for authentication. (create-a-container/migrations/20251105155228-create-sessions-table.js)API and Documentation Updates:
Updated the API documentation to include a new
DELETE /containers/:idendpoint for authenticated container deletion with proper authorization and cleanup. (create-a-container/README.md)Documented the new data model with an ER diagram and key constraints in the README. (
create-a-container/README.md)Dependency Additions and Configuration:
Added new dependencies for session storage (
express-session-sequelize), flash messaging (connect-flash), and HTTP method override (method-override). (create-a-container/package.json,create-a-container/package-lock.json) [1] [2] [3] [4] [5]Disabled SQL logging in the production Sequelize configuration. (
create-a-container/config/config.js)