Skip to content

Remove spaces from all directory and file names#18

Merged
horner merged 2 commits intomainfrom
copilot/fix-17
Sep 4, 2025
Merged

Remove spaces from all directory and file names#18
horner merged 2 commits intomainfrom
copilot/fix-17

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Sep 4, 2025

This PR addresses the issue of spaces in directory names that made URLs cumbersome and error-prone. Previously, accessing directories required URL encoding, creating unwieldy links like:

  • https://github.com/mieweb/opensource-server/tree/main/container%20creation
  • https://github.com/mieweb/opensource-server/tree/main/nginx%20reverse%20proxy

Changes made:

  • Renamed ci-cd automation/ci-cd-automation/
  • Renamed container creation/container-creation/
  • Renamed dnsmasq service/dnsmasq-service/
  • Renamed nginx reverse proxy/nginx-reverse-proxy/

Updated references:

  • Updated all directory references in the README.md mermaid diagram
  • Fixed directory links in the README.md documentation sections
  • Updated .gitmodules to reflect the new path for the Proxmox-Launchpad submodule
  • Re-initialized the submodule in the correct location

Result:

All URLs now use clean, dash-separated names that are easier to reference and share:

  • https://github.com/mieweb/opensource-server/tree/main/container-creation
  • https://github.com/mieweb/opensource-server/tree/main/nginx-reverse-proxy
  • https://github.com/mieweb/opensource-server/tree/main/ci-cd-automation
  • https://github.com/mieweb/opensource-server/tree/main/dnsmasq-service

No functionality is affected - only the directory names have changed to improve maintainability and usability.

Fixes #17.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copy link
Copy Markdown
Contributor Author

Copilot AI commented Sep 4, 2025

@horner 👋 This repository doesn't have Copilot instructions. With Copilot instructions, I can understand the repository better, work faster and produce higher quality PRs.

I can generate a .github/copilot-instructions.md file for you automatically. Click here to open a pre-filled issue and assign it to me. I'll write the instructions, and then tag you for review.

Co-authored-by: horner <6094599+horner@users.noreply.github.com>
Copilot AI changed the title [WIP] Remove spaces from all directory and file names Remove spaces from all directory and file names Sep 4, 2025
Copilot AI requested a review from horner September 4, 2025 01:59
@horner horner marked this pull request as ready for review September 4, 2025 03:11
@horner
Copy link
Copy Markdown
Member

horner commented Sep 4, 2025

@maxklema before I merge, I wonder if this is scary to you. I did not see that many cross references.

Copy link
Copy Markdown
Contributor

@maxklema maxklema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @horner. Not many cross-references because this repository is a combination of folders that are spread across our hypervisor and some core-infra containers. That's to say it's not an exact 1:1 replica, and folders on the actual machines use dashes (-) instead of spaces, unlike in this repository.

@horner horner merged commit c092302 into main Sep 4, 2025
@runleveldev runleveldev deleted the copilot/fix-17 branch October 14, 2025 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove spaces from all directory and file names

3 participants