Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions create-a-container/server.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
const express = require('express');
const bodyParser = require('body-parser');
const session = require('express-session');
const { spawn, exec } = require('child_process');
const { spawn, exec, execFile } = require('child_process');
const path = require('path');
const crypto = require('crypto');
const fs = require('fs'); // Added fs module
Expand Down Expand Up @@ -33,25 +33,25 @@
});

// Handles user login
app.post('/login', (req, res) => {
const { username, password } = req.body;

exec(`node /root/bin/js/runner.js authenticateUser ${username} ${password}`, (err, stdout) => {
execFile('node', ['/root/bin/js/runner.js', 'authenticateUser', username, password], (err, stdout) => {
if (err) {
console.error("Login script execution error:", err);
return res.status(500).json({ error: "Server error during authentication." });
}

if (stdout.trim() === 'true') {
req.session.user = username;
req.session.proxmoxUsername = username;
req.session.proxmoxPassword = password;
return res.json({ success: true, redirect: '/form.html' });
} else {
return res.status(401).json({ error: "Invalid credentials" });
}
});
});

Check failure

Code scanning / CodeQL

Missing rate limiting High

This route handler performs
a system command
, but is not rate-limited.

// ✨ UPDATED: API endpoint to get user's containers
app.get('/api/my-containers', (req, res) => {
Expand Down