Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
runleveldev
force-pushed
the
71-container-creation-cleanup-and-document
branch
from
c7af633 to
c7ddb76
Compare
runleveldev
force-pushed
the
71-container-creation-cleanup-and-document
branch
from
c7ddb76 to
1578fc9
Compare
cmyers-mieweb
approved these changes
Oct 20, 2025
Collaborator
cmyers-mieweb
left a comment
cmyers-mieweb
left a comment
There was a problem hiding this comment.
Looks Good, we will set this as a new baseline
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I want to throw out this mass of BASH and replace it with an actual system using pure NodeJS handled by create-a-container. All "frontends" (ssh, GH Actions, etc.) should just call back to the /containers/new API. We especially need to eliminate the mass of nested-ssh calls as root to other servers. We then need to audit authorized keys because I'm afraid there's been a lot of over-provisioning for permissions. In particular, all calls to
pctand family should be replaced by calls to the Proxmox API and use the user's credentials instead of root's.This PR does document what currently exists, and also re-organizes everything to match what's currently in-use on the cluster. The README will also include instructions on how to deploy changes to these files while we implement the replacements.