rewrite numbered params to positional params#5
Merged
mightyguava merged 2 commits intokotlin-masterfrom Jan 28, 2020
Merged
Conversation
This was referenced Jan 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JDBC seems to only support positional parameters like
?. I had to write a HACK to convert numbered parameters like$1to?. This is buggy and terrible. It also means that you can't use$1multiple times in the same query to reference the same value.This is a better change that examines the AST and edits the parser in the parsing step.
The Kotlin generation has a few extra nuances. The number of parameters no longer directly corresponds to the number of columns in the struct (data class) generated, since numbered parameters can be used multiple times. I work around it here by adding a new
JDBCParamBindingsfield toKtQueryValuesthat contains the full list of bindings that need to be passed to the driver. The existingKtQueryValues.Fieldsis used to generate the struct.