Skip to content

add bsl status to nonadmn bsl get#132

Merged
weshayutin merged 1 commit into
migtools:oadp-devfrom
weshayutin:velerostatus
Feb 18, 2026
Merged

add bsl status to nonadmn bsl get#132
weshayutin merged 1 commit into
migtools:oadp-devfrom
weshayutin:velerostatus

Conversation

@weshayutin
Copy link
Copy Markdown
Contributor

@weshayutin weshayutin commented Feb 18, 2026

Why the changes were made

fixes: #131

How to test the changes made

oc oadp nonadmin bsl get
NAME                           REQUEST PHASE   VELERO PHASE    PROVIDER        BUCKET/PREFIX        AGE       
nacuser1                       Created         Available       aws             wesoadpnacuser1/velero 20h   

Summary by CodeRabbit

Release Notes

  • New Features
    • Added a new "VELERO PHASE" column to the Backup Storage Location table, displaying the phase status of each backup storage location. Shows "N/A" when status information is unavailable.

Signed-off-by: Wesley Hayutin <weshayutin@gmail.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Feb 18, 2026

No actionable comments were generated in the recent review. 🎉


📝 Walkthrough

Walkthrough

Added a "VELERO PHASE" column to the non-admin BSL get command output. Introduced a helper function getBSLVeleroPhase that retrieves and displays the phase status from the Velero backup storage location, positioned between "REQUEST PHASE" and "PROVIDER" columns.

Changes

Cohort / File(s) Summary
Non-Admin BSL Display Enhancement
cmd/non-admin/bsl/get.go
Added getBSLVeleroPhase helper function and integrated "VELERO PHASE" column into the BSL table output, displaying the Velero backup storage location phase status (or "N/A" if unavailable).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Poem

🐰 A phase appears, so clear and bright,
The Velero status shows its light,
Between REQUEST and PROVIDER, there it gleams,
Making BSL info complete—fulfilling dreams! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title refers to adding BSL status to the nonadmin BSL get command, which aligns with the main change of adding the VELERO PHASE column.
Linked Issues check ✅ Passed The PR implements the core requirement from issue #131 by adding VELERO PHASE column to display BSL status in the nonadmin bsl get command output.
Out of Scope Changes check ✅ Passed All changes are directly related to adding the VELERO PHASE column functionality required by issue #131; no extraneous modifications detected.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@Joeavaikath
Copy link
Copy Markdown
Contributor

This already seems to be a part of #134

@weshayutin weshayutin merged commit 66e52b5 into migtools:oadp-dev Feb 18, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

nonadmin bsl get needs to show the status of the bsl

2 participants