[oadp-1.6] Rename VERSION to OADP_VERSION in konflux.Dockerfile#185
Conversation
Konflux auto-injects VERSION as the Go toolchain version from the builder image (e.g. 1.25), which collides with our VERSION build arg used for buildinfo.Version. This causes the CLI to report the Go version instead of the OADP version. Rename to OADP_VERSION to avoid the collision. Release branches should hardcode the appropriate version (e.g. v1.6.0). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Keep consistent with konflux.Dockerfile change. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: openshift-cherrypick-robot, shubham-pampattiwar The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3 participants
This is an automated cherry-pick of #184
/assign Joeavaikath