Cherry-pick: Fix CLI version in Konflux builds#187
Conversation
Rename VERSION to OADP_VERSION in konflux.Dockerfile
…version Use ART-injected env vars for version in Konflux builds
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Joeavaikath, kaovilai, shubham-pampattiwar The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Summary
Cherry-pick of #184 and #186 to oadp-1.6.
VERSIONtoOADP_VERSIONinContainerfile.downloadto avoid collision with Konflux-injectedVERSION(Go toolchain version)BUILD_VERSIONandSOURCE_GIT_COMMITenv vars inkonflux.Dockerfilefor correct version infooc oadp versionreportingVersion: 1.25(Go version) instead of the actual OADP versionTest plan
Version: 1.6.0Git commitshows the correct SHA🤖 Generated with Claude Code