Conditional krew index PR and multiarch binary server#85
Conversation
Signed-off-by: Joseph <jvaikath@redhat.com>
Signed-off-by: Joseph <jvaikath@redhat.com>
There was a problem hiding this comment.
Can you make this run on pull request but not push if pull request?
Signed-off-by: Joseph <jvaikath@redhat.com>
Signed-off-by: Joseph <jvaikath@redhat.com>
Signed-off-by: Joseph <jvaikath@redhat.com>
Signed-off-by: Joseph <jvaikath@redhat.com>
| with: | ||
| image: quay.io/konveyor/oadp-cli-binaries | ||
| tags: ${{ github.ref_type == 'tag' && format('latest {0}', github.ref_name) || 'test' }} | ||
| archs: amd64,arm64,ppc64le,s390x |
There was a problem hiding this comment.
building for ppc and s390 will be wasted effort here
There was a problem hiding this comment.
@weshayutin This container IIUC will be running on the ppc and s390 cluster to serve the CLI.
each container, ppc or s390x will be serving amd64, arm64 binaries for download.
There was a problem hiding this comment.
Without s390x or ppc image of quay.io/konveyor/oadp-cli-binaries, the cluster won't be able to serve these binaries to end users.
There was a problem hiding this comment.
@weshayutin comment if applicable would apply to
Line 14 in 1c86f89
Not this download server container.
There was a problem hiding this comment.
unless p & z QE are going to install from oadp-dev, which they will not.. IMHO it's a waste. It will be built downstream on p & z
There was a problem hiding this comment.
Just so that any oadp-operator installs on those archs don't hang/fail on the binary server pod start
There was a problem hiding this comment.
It's ok GitHub action is free 😁
| buildah manifest create oadp-cli-binaries | ||
|
|
||
| buildah build \ | ||
| --platform=linux/amd64,linux/arm64,linux/ppc64le,linux/s390x \ |
There was a problem hiding this comment.
Unless we won't be running this server on ppc or s390x, I would revert this change.
oadp-cli/Containerfile.download
Line 36 in 1c86f89
cc: @weshayutin
There was a problem hiding this comment.
removed them, focusing on amd64 and arm64 for now
Signed-off-by: Joseph <jvaikath@redhat.com>
Signed-off-by: Joseph <jvaikath@redhat.com>
Signed-off-by: Joseph <jvaikath@redhat.com>
|
Okay this should be good |
Signed-off-by: Joseph <jvaikath@redhat.com>
Signed-off-by: Joseph <jvaikath@redhat.com>
Signed-off-by: Joseph <jvaikath@redhat.com>
|
Tested on local branch, looks good |
3 participants
Why the changes were made
How to test the changes made