v1.5: Add downstream Dockerfile#274
Conversation
In support of enabling Konflux builds directly from repo.
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
|
@shubham-pampattiwar please review to merge |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kaovilai, rayfordj, shubham-pampattiwar, weshayutin The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
if possible, change file name to oadp.Dockerfile (or something similar) so we have right file extension and syntax highlighting
There was a problem hiding this comment.
No objection. However, I was following prior-art found across OpenShift Org repos where this appears the accepted pattern...
- Dockerfile.ubi
- Dockerfile-velero-restore-helper.ubi
- Dockerfile.microshift
- Dockerfile.mustgather
- Dockerfile.openshift
- Many examples using
.openshift&.ocp
- Many examples using
- Speed round without referring links 😅
- Dockerfile.admission-webhook.ocp
- Dockerfile.art
- Dockerfile.aws-ebs
- Dockerfile.aws-efs
- Dockerfile.azure-disk
- Dockerfile.azure-file
6 participants
In support of enabling Konflux builds directly from repo.