[oadp-1.5] Check the NaBSL status and conditions before creating Velero Backup#284
Merged
openshift-merge-bot[bot] merged 4 commits intoMay 16, 2025
Conversation
Fixes migtools#246 Ensure the state of the NaBSL is satisfying the Backup operation, in a case the admin redefined enforcement the NaBSL state was correctly synced back from the enforcement, however we disallowed real updated of the Velero BSL object causing NaBSL being in not allowed state, however previous Velero BSL fully functional. This logic fixes that issue. Signed-off-by: Michal Pryc <mpryc@redhat.com>
We should faily only when specific conditions are False, not all of them. Signed-off-by: Michal Pryc <mpryc@redhat.com>
Remove conditions check for the NaBSL check prior to creating backup. This is enough as the NaBSL must be in created state after satisfying all the conditions. Signed-off-by: Michal Pryc <mpryc@redhat.com>
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
Update go.mod and go.sum to match the oadp-operator oadp-1.5 branch. Signed-off-by: Michal Pryc <mpryc@redhat.com>
Collaborator
|
@shubham-pampattiwar pls review. |
weshayutin
approved these changes
May 16, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: openshift-cherrypick-robot, shubham-pampattiwar, weshayutin The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for: OADP-6139
This is an automated cherry-pick of #249
/assign mpryc