Don't block unix sockets

[joetsoi]

This is a pretty dumb implementation and I'm happy to rework it to be a bit safer/defensive, just wanted to test if it worked first. It fixes issues with asyncio by check if it's an AF_UNIX domain socket being requested and allowing that, otherwise it blocks as normal.

should help with

#47
#6

I've tested it with both the starlette example and the asynctest example and both work with this patch

import asynctest

class TestClass(asynctest.TestCase):
    async def test_something(self):
        pass

[alex-verve]

Tested on five Django projects and it works like a charm 👍
I don't need to patch django via env var anymore, thanks for your work!

[miketheman]

Excellent, thanks for taking this on! I think this was recently enabled by converting this to a class, so yay!

I'm currently moving, so haven't had a change to check it out more thoroughly, but could you consider adding your test case to the tests so the functionality is exercised by CI?

Also, had you considered making this a configuration flag like --allow-unix-sockets so that the behavior can be controlled by the user? This way it's opt-in, and not a change of the current default behavior.

[joetsoi]

happy to do both! just wanted to throw this out there before investing too much time in it

[joetsoi]

Windows failure looks like an unrelated failure on setup. Not the absence of AF_UNIX that I was hoping to test

[joetsoi]

@miketheman, no pressure, just a ping hoping you find some time to take a look at this.

[miketheman]

Thanks for adding tests and a toggle! Change requested in the test logic - see inline!

[miketheman]

I also reran the test suite and the failing Windows test passed, so that's something we should keep an eye on - nothing worse than a flaky test!

[qlty-cloud-legacy]

Code Climate has analyzed commit 197d3e3 and detected 0 issues on this pull request.

View more on Code Climate.

[miketheman]

Thanks for sticking with it!
I’ll try to get to a release next week.