Skip to content

Conversation

@remorses
Copy link
Contributor

@remorses remorses commented Apr 16, 2023

To support latest diffusers you also need to wait for this PR

@mikonvergence
Copy link
Owner

Yeah, I just realised the positional arg do_classifier_free_guidance is also causing problems with the latest release.

Let's see if that can be fixed in the PR you mentioned on the diffusers side. If it doesn't get resolved in the next week or so, we can adjust the code in this repo.

For now, I will make it explicit that diffusers==0.14.0 is currently supported.

@mikonvergence
Copy link
Owner

@remorses It seems that the issue does not occur with 0.16.0? Is it okay to close this down?

@remorses
Copy link
Contributor Author

I would merge this PR because direct use of model parameters is discouraged, it’s better to use the config object

feel free to close the PR if you don’t want to

@mikonvergence
Copy link
Owner

Right, there is that too. I agree, will merge it then.

@mikonvergence mikonvergence merged commit 4f48c84 into mikonvergence:main Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants