Skip to content

Use Parameter.CreateParameter() factory pattern #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicholi merged 1 commit into from
Feb 5, 2026
Merged

Use Parameter.CreateParameter() factory pattern #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DigitalOcean.API/Clients/ActionsClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ public Task<IReadOnlyList<Action>> GetAll() {
/// </summary>
public Task<Action> Get(long actionId) {
var parameters = new List<Parameter> {
new UrlSegmentParameter("id", actionId.ToString())
Parameter.CreateParameter("id", actionId.ToString(), ParameterType.UrlSegment)
};
return _connection.ExecuteRequest<Action>("actions/{id}", parameters, null, "action");
}
Expand Down
16 changes: 8 additions & 8 deletions DigitalOcean.API/Clients/AppsClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,30 +22,30 @@ public Task<IReadOnlyList<App>> ListAllApps() {

public Task<App> RetrieveExistingApp(string appId) {
var parameters = new List<Parameter> {
new UrlSegmentParameter("appId", appId)
Parameter.CreateParameter("appId", appId, ParameterType.UrlSegment)
};
return _connection.ExecuteRequest<App>("apps/{appId}", parameters, null, "app");
}

public Task<IReadOnlyList<Deployment>> ListAppDeployments(string appId) {
var parameters = new List<Parameter> {
new UrlSegmentParameter("appId", appId)
Parameter.CreateParameter("appId", appId, ParameterType.UrlSegment)
};
return _connection.GetPaginated<Deployment>("apps/{appId}/deployments", parameters, "deployments");
}

public Task<Deployment> RetrieveAppDeployment(string appId, string deploymentId) {
var parameters = new List<Parameter> {
new UrlSegmentParameter("appId", appId),
new UrlSegmentParameter("deploymentId", deploymentId)
Parameter.CreateParameter("appId", appId, ParameterType.UrlSegment),
Parameter.CreateParameter("deploymentId", deploymentId, ParameterType.UrlSegment)
};
return _connection.ExecuteRequest<Deployment>("apps/{appId}/deployments/{deploymentId}", parameters, null,
"deployment");
}

public Task DeleteApp(string appId) {
var parameters = new List<Parameter> {
new UrlSegmentParameter("appId", appId)
Parameter.CreateParameter("appId", appId, ParameterType.UrlSegment)
};
return _connection.ExecuteRaw("apps/{appId}", parameters, null, Method.Delete);
}
Expand All @@ -56,7 +56,7 @@ public Task<App> CreateNewApp(Specs specs) {

public Task<Deployment> CreateNewDeployment(string appId, ForceBuildApp forceBuild) {
var parameters = new List<Parameter> {
new UrlSegmentParameter("appId", appId)
Parameter.CreateParameter("appId", appId, ParameterType.UrlSegment)
};

return _connection.ExecuteRequest<Deployment>("apps/{appId}/deployments", parameters,
Expand All @@ -65,8 +65,8 @@ public Task<Deployment> CreateNewDeployment(string appId, ForceBuildApp forceBui

public Task<Deployment> CancelDeployment(string appId, string deploymentId) {
var parameters = new List<Parameter> {
new UrlSegmentParameter("appId", appId),
new UrlSegmentParameter("deploymentId", deploymentId)
Parameter.CreateParameter("appId", appId, ParameterType.UrlSegment),
Parameter.CreateParameter("deploymentId", deploymentId, ParameterType.UrlSegment)
};
return _connection.ExecuteRequest<Deployment>("apps/{appId}/deployments/{deploymentId}", parameters, null,
"deployment", Method.Post);
Expand Down
8 changes: 4 additions & 4 deletions DigitalOcean.API/Clients/CdnEndpointsClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ public Task<IReadOnlyList<CdnEndpoint>> GetAll() {
/// </summary>
public Task<CdnEndpoint> Get(string endpointId) {
var parameters = new List<Parameter> {
new UrlSegmentParameter ("endpoint_id", endpointId)
Parameter.CreateParameter("endpoint_id", endpointId, ParameterType.UrlSegment)
};
return _connection.ExecuteRequest<CdnEndpoint>("cdn/endpoints/{endpoint_id}", parameters, null, "endpoint");
}
Expand All @@ -42,7 +42,7 @@ public Task<CdnEndpoint> Create(Models.Requests.CdnEndpoint endpoint) {
/// </summary>
public Task<CdnEndpoint> Update(string endpointId, Models.Requests.UpdateCdnEndpoint updateEndpoint) {
var parameters = new List<Parameter> {
new UrlSegmentParameter ("endpoint_id", endpointId)
Parameter.CreateParameter("endpoint_id", endpointId, ParameterType.UrlSegment)
};
return _connection.ExecuteRequest<CdnEndpoint>("cdn/endpoints/{endpoint_id}", parameters, updateEndpoint, "endpoint", Method.Put);
}
Expand All @@ -52,7 +52,7 @@ public Task<CdnEndpoint> Update(string endpointId, Models.Requests.UpdateCdnEndp
/// </summary>
public Task Delete(string endpointId) {
var parameters = new List<Parameter> {
new UrlSegmentParameter ("endpoint_id", endpointId)
Parameter.CreateParameter("endpoint_id", endpointId, ParameterType.UrlSegment)
};
return _connection.ExecuteRaw("cdn/endpoints/{endpoint_id}", parameters, null, Method.Delete);
}
Expand All @@ -64,7 +64,7 @@ public Task Delete(string endpointId) {
/// </summary>
public Task PurgeCache(string endpointId, Models.Requests.PurgeCdnFiles purgeFiles) {
var parameters = new List<Parameter> {
new UrlSegmentParameter ("endpoint_id", endpointId)
Parameter.CreateParameter("endpoint_id", endpointId, ParameterType.UrlSegment)
};
return _connection.ExecuteRaw("cdn/endpoints/{endpoint_id}/cache", parameters, purgeFiles, Method.Delete);
}
Expand Down
4 changes: 2 additions & 2 deletions DigitalOcean.API/Clients/CertificatesClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ public Task<IReadOnlyList<Certificate>> GetAll() {
/// </summary>
public Task<Certificate> Get(string certificateId) {
var parameters = new List<Parameter> {
new UrlSegmentParameter ("certificate_id", certificateId)
Parameter.CreateParameter("certificate_id", certificateId, ParameterType.UrlSegment)
};
return _connection.ExecuteRequest<Certificate>("certificates/{certificate_id}", parameters, null, "certificate");
}
Expand All @@ -47,7 +47,7 @@ public Task<Certificate> Create(Models.Requests.Certificate certificate) {
/// </summary>
public Task Delete(string certificateId) {
var parameters = new List<Parameter> {
new UrlSegmentParameter ("certificate_id", certificateId)
Parameter.CreateParameter("certificate_id", certificateId, ParameterType.UrlSegment)
};
return _connection.ExecuteRaw("certificates/{certificate_id}", parameters, null, Method.Delete);
}
Expand Down
26 changes: 13 additions & 13 deletions DigitalOcean.API/Clients/ContainerRegistryClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ public Task ValidateName(ContainerRegistryValidateName containerRegistryValidate
/// </summary>
public Task<IReadOnlyList<ContainerRegistryRepository>> GetAllRepositories(string registryName) {
var parameters = new List<Parameter> {
new UrlSegmentParameter (nameof(registryName), registryName)
Parameter.CreateParameter(nameof(registryName), registryName, ParameterType.UrlSegment)
};

return _connection.GetPaginated<ContainerRegistryRepository>($"registry/{{{nameof(registryName)}}}/repositories", parameters, "repositories");
Expand All @@ -82,8 +82,8 @@ public Task<IReadOnlyList<ContainerRegistryRepository>> GetAllRepositories(strin
/// </summary>
public Task<IReadOnlyList<ContainerRegistryTag>> GetAllRepositoryTags(string registryName, string repositoryName) {
var parameters = new List<Parameter> {
new UrlSegmentParameter (nameof(registryName), registryName),
new UrlSegmentParameter (nameof(repositoryName), repositoryName),
Parameter.CreateParameter(nameof(registryName), registryName, ParameterType.UrlSegment),
Parameter.CreateParameter(nameof(repositoryName), repositoryName, ParameterType.UrlSegment),
};

return _connection.GetPaginated<ContainerRegistryTag>($"registry/{{{nameof(registryName)}}}/repositories/{{{nameof(repositoryName)}}}/tags", parameters, "tags");
Expand All @@ -94,9 +94,9 @@ public Task<IReadOnlyList<ContainerRegistryTag>> GetAllRepositoryTags(string reg
/// </summary>
public Task DeleteRepositoryTag(string registryName, string repositoryName, string tag) {
var parameters = new List<Parameter> {
new UrlSegmentParameter (nameof(registryName), registryName),
new UrlSegmentParameter (nameof(repositoryName), repositoryName),
new UrlSegmentParameter (nameof(tag), tag),
Parameter.CreateParameter(nameof(registryName), registryName, ParameterType.UrlSegment),
Parameter.CreateParameter(nameof(repositoryName), repositoryName, ParameterType.UrlSegment),
Parameter.CreateParameter(nameof(tag), tag, ParameterType.UrlSegment),
};

return _connection.ExecuteRaw($"registry/{{{nameof(registryName)}}}/repositories/{{{nameof(repositoryName)}}}/tags/{{{nameof(tag)}}}", parameters, null, Method.Delete);
Expand All @@ -107,8 +107,8 @@ public Task DeleteRepositoryTag(string registryName, string repositoryName, stri
/// </summary>
public Task DeleteRepositoryManifest(string registryName, string repositoryName, string manifestDigest) {
var parameters = new List<Parameter> {
new UrlSegmentParameter (nameof(registryName), registryName),
new UrlSegmentParameter (nameof(repositoryName), repositoryName),
Parameter.CreateParameter(nameof(registryName), registryName, ParameterType.UrlSegment),
Parameter.CreateParameter(nameof(repositoryName), repositoryName, ParameterType.UrlSegment),
};

return _connection.ExecuteRaw($"registry/{{{nameof(registryName)}}}/repositories/{{{nameof(repositoryName)}}}/digests/{manifestDigest}", parameters, null, Method.Delete);
Expand All @@ -119,7 +119,7 @@ public Task DeleteRepositoryManifest(string registryName, string repositoryName,
/// </summary>
public Task<GarbageCollection> StartGarbageCollection(string registryName) {
var parameters = new List<Parameter> {
new UrlSegmentParameter (nameof(registryName), registryName),
Parameter.CreateParameter(nameof(registryName), registryName, ParameterType.UrlSegment),
};

return _connection.ExecuteRequest<GarbageCollection>($"registry/{{{nameof(registryName)}}}/garbage-collection", parameters, null, "garbage_collections", Method.Post);
Expand All @@ -130,7 +130,7 @@ public Task<GarbageCollection> StartGarbageCollection(string registryName) {
/// </summary>
public Task<GarbageCollection> GetActiveGarbageCollection(string registryName) {
var parameters = new List<Parameter> {
new UrlSegmentParameter (nameof(registryName), registryName),
Parameter.CreateParameter(nameof(registryName), registryName, ParameterType.UrlSegment),
};

return _connection.ExecuteRequest<GarbageCollection>($"registry/{{{nameof(registryName)}}}/garbage-collection", parameters, null, "garbage_collections");
Expand All @@ -141,7 +141,7 @@ public Task<GarbageCollection> GetActiveGarbageCollection(string registryName) {
/// </summary>
public Task<IReadOnlyList<GarbageCollection>> GetAllGarbageCollections(string registryName) {
var parameters = new List<Parameter> {
new UrlSegmentParameter (nameof(registryName), registryName),
Parameter.CreateParameter(nameof(registryName), registryName, ParameterType.UrlSegment),
};

return _connection.GetPaginated<GarbageCollection>($"registry/{{{nameof(registryName)}}}/garbage-collections", parameters, "garbage_collections");
Expand All @@ -152,8 +152,8 @@ public Task<IReadOnlyList<GarbageCollection>> GetAllGarbageCollections(string re
/// </summary>
public Task<GarbageCollection> UpdateGarbageCollection(string registryName, string uuid, UpdateGarbageCollection updateGarbageCollection) {
var parameters = new List<Parameter> {
new UrlSegmentParameter (nameof(registryName), registryName),
new UrlSegmentParameter (nameof(uuid), uuid),
Parameter.CreateParameter(nameof(registryName), registryName, ParameterType.UrlSegment),
Parameter.CreateParameter(nameof(uuid), uuid, ParameterType.UrlSegment),
};

return _connection.ExecuteRequest<GarbageCollection>($"registry/{{{nameof(registryName)}}}/garbage-collection/{{{nameof(uuid)}}}", parameters, updateGarbageCollection, "garbage_collections", Method.Put);
Expand Down
Loading