vertico-buffer-mode changing affixations

[dgillis]

Using vertico-buffer-mode, I notice some M-x commands not displaying their key binding annotations. It appears this is due to the key lookup (via where-is-internal) getting called with the minibuffer as the current buffer (so key bindings specific to the original are not found). Whereas when not using vertico-buffer-mode, the annotated keys are accurate since the lookup is done with the original buffer as current.

Is this something that can/should be fixed within vertico? It seems this issue occurs both with and without marginalia-mode (the former due to the builtin read-extended-command--affixation and the latter due to marginalia-annotate-binding). So there doesn't seem to be a straightforward fix outside vertico.

EDIT to add: I think there's one more precondition needed to reproduce this. My preference is for the completion candidates to use the current window, so I have (setq vertico-buffer-display-action '(display-buffer-same-window). Without that the problem does not occur.

[minad]

I think this cannot be fixed. Marginalia needs to run in the original window, see the comment https://github.com/minad/marginalia/blob/c3e7b1904423bda143249c0d02cbb7cc7ed8bee0/marginalia.el#L1300-L1303. And if you change the original window, that's what you get.

[dgillis]

What about setting both the selected window and current buffer back to the original. Like:

     (with-selected-window (or (minibuffer-selected-window) (selected-window))
          (with-current-buffer old-buf

I don't know how to determine "old-buf" at this point though. Do vertico or marginalia keep track of the initial buffer anywhere? If not, do you know of a good place I could grab this to try to advice my way around this?

I'm surprised this hasn't been a frequently encountered problem. I guess very few people are using '(display-buffer-same-window) as their vertico-buffer-display-action. If that's the case maybe I should give up on it, I've encountered other rough edges with it.

[minad]

Yes, I think display-buffer-same-window causes too many problems (for Marginalia and Consult preview) - it is not a setting I recommend for vertico-buffer. You could try to use the variable minibuffer--original-buffer.

[dgillis]

Thanks. Using minibuffer--original-buffer as current buffer inside marginalia--affixate like below fixes the issue for me.

Also, the same problem occurs when using the vertico-buffer-display-action custom choice '(display-buffer-reuse-window).

Are you open to a marginalia PR along those lines?

[minad]

Pushed the fix here: minad/marginalia@61bf019. I hope it doesn't cause other issues to the inconsistency between selected window and current buffer.

[dgillis]

Great. Thanks so much :)