fix: enable vision support for OpenAI-compatible client#153
Open
hazemahmedx0 wants to merge 3 commits into
Open
fix: enable vision support for OpenAI-compatible client#153hazemahmedx0 wants to merge 3 commits into
hazemahmedx0 wants to merge 3 commits into
Conversation
Set supports_vision=True so vision-capable models routed through the OpenAI-compatible client can process image inputs.
|
All contributors have signed the CLA ✍️ ✅ |
Adds a vision_format option ("openai" | "anthropic") to OpenAIProvider
and the message translation functions. Endpoints like MDB.AI that speak
Anthropic content format over an OpenAI-compatible HTTP envelope need
image blocks kept as-is rather than converted to image_url format.
Confidence Score: 5/5 - Safe to MergeSafe to merge — this PR enables vision support for OpenAI-compatible clients, a well-scoped feature addition with no identified issues from automated or manual review analysis. The change appears clean with no logic bugs, security concerns, or regressions surfaced during review. No pre-existing unresolved comments are associated with this PR. Key Findings:
|
Member
Author
|
I have read the CLA Document and I hereby sign the CLA |
hazemahmedx0
requested review from
MinuraPunchihewa,
StpMax,
ZoranPandovski and
tino097
and removed request for
MinuraPunchihewa,
ZoranPandovski and
tino097
…d memory When user_input is a list of content blocks (image + text), user_msg_str was falling back to "" — losing the text context for system prompt building and episodic memory logging. Extract the first text block instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
supports_vision=Truein the OpenAI-compatible client config (client.py:235)Test plan