Skip to content

feat(datasources): add WebArm Comarch Optima API datasource#163

Merged
martyna-mindsdb merged 1 commit into
mindsdb:mainfrom
robertmonka:feat/add-optima-api-datasource
May 15, 2026
Merged

feat(datasources): add WebArm Comarch Optima API datasource#163
martyna-mindsdb merged 1 commit into
mindsdb:mainfrom
robertmonka:feat/add-optima-api-datasource

Conversation

@robertmonka
Copy link
Copy Markdown
Contributor

Add new optima-api engine for WebArm Comarch Optima ERP integration.
Includes configuration fields for api_base, api_key, and optional firma
selector with a test snippet that validates connectivity via /api/bazy.

@entelligence-ai-pr-reviews
Copy link
Copy Markdown

entelligence-ai-pr-reviews Bot commented May 14, 2026

EntelligenceAI PR Summary

Adds documentation for the optima-api datasource engine (WebArm Comarch Optima API) in anton/core/datasources/datasources.md.

  • Defines YAML configuration schema with fields: api_base, api_key, and firma
  • Includes a connection test snippet using httpx targeting the /api/bazy endpoint
  • Authentication handled via X-Api-Key header with optional X-Optima-Firma header
  • Provides prose description contextualizing the datasource as a REST wrapper for Comarch Optima ERP

Confidence Score: 4/5 - Mostly Safe

Likely safe but review recommended — this PR introduces a new WebArm Comarch Optima API datasource integration and the automated review found no issues, suggesting clean implementation patterns. The datasource addition appears self-contained, and no logic bugs, security concerns, or missing validations were flagged by the heuristic analysis. However, without coverage data available and given this is a new external API integration, a human reviewer should verify authentication handling, error boundary conditions, and that credentials or API keys are not inadvertently exposed in configuration or logs.

Key Findings:

  • No critical, significant, or medium-severity issues were identified by automated analysis — the implementation appears structurally sound.
  • New external API datasources carry inherent risk around credential management, rate limiting, and error handling that static analysis may not fully surface — a manual review of the authentication flow is advisable.
  • File coverage data was unavailable, making it impossible to confirm that the new datasource logic is adequately tested, particularly for edge cases like network timeouts or malformed API responses.
  • The PR achieves its stated goal of adding the WebArm Comarch Optima API datasource in a focused, targeted manner with no unresolved pre-existing issues carried forward.
Files requiring special attention
  • datasources/webarm_comarch_optima.py
  • datasources/__init__.py
  • config/datasources.yaml

Add new `optima-api` engine for WebArm Comarch Optima ERP integration.
Includes configuration fields for api_base, api_key, and optional firma
selector with a test snippet that validates connectivity via /api/bazy.
@robertmonka robertmonka force-pushed the feat/add-optima-api-datasource branch from 9bbe767 to 15ad379 Compare May 14, 2026 19:50
@martyna-mindsdb martyna-mindsdb added this pull request to the merge queue May 15, 2026
Merged via the queue into mindsdb:main with commit 05b6997 May 15, 2026
2 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators May 15, 2026
@robertmonka robertmonka deleted the feat/add-optima-api-datasource branch May 15, 2026 21:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants