Lock the PID file when creating or deleting it#12232
Merged
Merged
Conversation
ea-rus
approved these changes
Feb 20, 2026
| except Exception: | ||
| pass | ||
| logger.warning(f"Found existing PID file {pid_file} but it is not a valid JSON, removing") | ||
| lock_file = p.joinpath("pid.lock") |
Collaborator
There was a problem hiding this comment.
maybe to lock pid file instead?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Lock PID file to prevent race-condition issues, like:
ProcessA: pid_file.exists() → False
ProcessB: pid_file.exists() → False
ProcessA: write to pid file
ProcessB: write to pid file → Error
Fixes #FQE-1878
Type of change
(Please delete options that are not relevant)
Verification Process
To ensure the changes are working as expected:
Additional Media:
Checklist: