Skip to content

Conversation

@bornagojsic
Copy link

@bornagojsic bornagojsic commented Sep 4, 2023

added docs for new features in armory

@bornagojsic bornagojsic self-assigned this Sep 4, 2023
@bornagojsic bornagojsic requested a review from lbenjak September 4, 2023 10:54
@lbenjak
Copy link
Contributor

lbenjak commented Sep 5, 2023

I like the content, and this is the part where you don't have to make changes. On the other hand, I think we need to change how we present that content.

First, there are better options than this toggle view because, this way, the content gets lost. I would make another subheader and put everything from the toggle as a separate paragraph.

Also, there needs to be a bit of context added. If I am reading this from the perspective of someone who's getting familiar with Armory, I would be confused with this out-of-nowhere configuration. Why do we need it? Where can we find it? Is this the only way of using it? Answers to this kind of questions is the context that is missing.

@bornagojsic, we should make a new iteration with all the comments I listed above. If you need any help or more guidance, please ask away.

@hlupek
Copy link
Collaborator

hlupek commented Sep 8, 2023

I like the content, and this is the part where you don't have to make changes. On the other hand, I think we need to change how we present that content.

First, there are better options than this toggle view because, this way, the content gets lost. I would make another subheader and put everything from the toggle as a separate paragraph.

Also, there needs to be a bit of context added. If I am reading this from the perspective of someone who's getting familiar with Armory, I would be confused with this out-of-nowhere configuration. Why do we need it? Where can we find it? Is this the only way of using it? Answers to this kind of questions is the context that is missing.

@bornagojsic, we should make a new iteration with all the comments I listed above. If you need any help or more guidance, please ask away.

Reviewed the suggestions, and implemented them!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants