Skip to content

Feature/fix update instace#272

Merged
kevin-mindverse merged 2 commits intodevelopfrom
feature/fixUpdateInstaceId
Apr 23, 2025
Merged

Feature/fix update instace#272
kevin-mindverse merged 2 commits intodevelopfrom
feature/fixUpdateInstaceId

Conversation

@kevin-mindverse
Copy link
Copy Markdown
Contributor

Refactor and improve instance credential management

Description

Refactored the instance credential management system to improve security, reliability, and maintainability. The current implementation had several issues related to load record management and credential updating.

Changes implemented

  1. Renamed update_instance_id method to update_instance_credentials to better reflect its purpose of updating both instance ID and password.
  2. Enhanced error handling to properly validate and report issues during credential updates.
  3. Modified the implementation to properly fetch the current load record instead of using a simplistic query that could lead to incorrect record updates.
  4. Ensured consistent parameter handling for both instance ID and password.
  5. Updated all references to the renamed method across the codebase.

Technical Details

  • Fixed potentially incorrect load record selection in credential update logic by using the proper get_current_load() method
  • Improved logging by masking sensitive password information
  • Added more descriptive error messages to aid in troubleshooting
  • Ensuring data consistency by verifying record existence at multiple steps

Affected Components

  • LoadService (load_service.py)
  • Upload API (routes.py)

@kevin-mindverse kevin-mindverse merged commit ce9cfcb into develop Apr 23, 2025
1 check passed
Cybercricetus pushed a commit to Cybercricetus/Second-Me that referenced this pull request May 29, 2025
* fix password update logic, if there's more than one load

* update fix
EOMZON pushed a commit to EOMZON/Second-Me that referenced this pull request Feb 1, 2026
* fix password update logic, if there's more than one load

* update fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants