Skip to content

update secret keys header#9

Merged
JakubMini merged 1 commit into
mainfrom
edit-keys-injection
May 5, 2026
Merged

update secret keys header#9
JakubMini merged 1 commit into
mainfrom
edit-keys-injection

Conversation

@JakubMini
Copy link
Copy Markdown
Contributor

@JakubMini JakubMini commented May 5, 2026

✨ New Features

DESFire default configuration support in secret keys header

🔧 Improvements

Clearer action description of header generation behavior

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 5, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 63c84fc5-7fee-4573-841f-bf2cac4e034f

📥 Commits

Reviewing files that changed from the base of the PR and between 3c749e5 and 88349ca.

📒 Files selected for processing (2)
  • actions/inject-keys/action.yml
  • actions/inject-keys/gen_secret_keys_header.py

Walkthrough

This pull request updates the key injection action and its supporting generator script to incorporate DESFire configuration defaults. The action's metadata description was revised to indicate that secret_keys.h is now generated from four provided hex keys combined with DESFire defaults. The Python generator script was correspondingly updated: its usage documentation was refreshed, the C header template was expanded to define a set of DESFIRE_* configuration macros (such as DESFIRE_ENABLED, DESFIRE_AID_BYTES, DESFIRE_FILE_ID, and others), and key constants are now output with explicit ULL suffixes for proper long literal formatting. The core function signatures and parsing logic remain unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~15 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'update secret keys header' is vague and generic, using non-descriptive language that doesn't convey what specifically changed or why the update matters. Consider a more specific title like 'Add DESFire configuration macros to secret keys header' or 'Update secret keys header with DESFire defaults and expanded configuration' to clearly indicate the main change.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch edit-keys-injection

Comment @coderabbitai help to get the list of available commands and usage tips.

@JakubMini JakubMini merged commit c3be2d1 into main May 5, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant