Skip to content

Conversation

@adfost
Copy link
Contributor

@adfost adfost commented Feb 10, 2022

Adds API and UI for editing service account policy.

@adfost adfost added the WIP This PR is WIP and cannot be merged yet label Feb 10, 2022
@adfost adfost self-assigned this Feb 10, 2022
@adfost adfost force-pushed the edit_service_account_policy_ui branch from 8aa5401 to f2568e5 Compare February 10, 2022 21:32
@adfost adfost removed the WIP This PR is WIP and cannot be merged yet label Feb 10, 2022
@adfost adfost requested a review from cniackz February 10, 2022 21:36
Copy link
Collaborator

@cniackz cniackz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, it works now.
Looks good to me.
Thank you @adfost for adding the tests!

Copy link
Collaborator

@bexsoft bexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dvaldivia dvaldivia merged commit 2988de4 into minio:master Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants