Skip to content

Conversation

@prakashsvmx
Copy link
Member

@prakashsvmx prakashsvmx commented Apr 7, 2022

UI for site replication

How does it look:

S1
S2
image

S4
image

Site Replication status would be in a new PR.

@prakashsvmx prakashsvmx self-assigned this Apr 7, 2022
@prakashsvmx prakashsvmx force-pushed the ui-site-replication branch from 74261a3 to c03cdeb Compare April 7, 2022 15:22
@prakashsvmx prakashsvmx marked this pull request as ready for review April 7, 2022 15:36
Copy link

@oscarocastellanos oscarocastellanos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dvaldivia
Copy link
Collaborator

@oscarocastellanos my only concern is that the Delete an Edit action buttons are different from everywhere else in the UI, should we adopt those squared icon buttons instead of the flat one or the circle ones? (which we should also make consistent btw hahaha)
Screen Shot 2022-04-07 at 10 19 37 AM

Screen Shot 2022-04-07 at 10 20 00 AM

@oscarocastellanos
Copy link

@oscarocastellanos my only concern is that the Delete an Edit action buttons are different from everywhere else in the UI, should we adopt those squared icon buttons instead of the flat one or the circle ones? (which we should also make consistent btw hahaha) Screen Shot 2022-04-07 at 10 19 37 AM

Screen Shot 2022-04-07 at 10 20 00 AM

You're right @dvaldivia, this slipped past me. Yeah, we should stick to the circle ones and try to keep them consistent everywhere.

Copy link

@oscarocastellanos oscarocastellanos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, let's use the action buttons for delete as circular style, as we use on other screens:
Captura de Pantalla 2022-04-07 a la(s) 12 26 39

@prakashsvmx prakashsvmx force-pushed the ui-site-replication branch from 803073f to 07056a1 Compare April 8, 2022 04:06
@prakashsvmx
Copy link
Member Author

@dvaldivia , @oscarocastellanos - I will continue to update the pages for consistency

@prakashsvmx prakashsvmx force-pushed the ui-site-replication branch from d846360 to f29df4c Compare April 8, 2022 04:50
Copy link

@oscarocastellanos oscarocastellanos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dvaldivia dvaldivia merged commit ee3affd into minio:master Apr 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants