Skip to content

Conversation

@cniackz
Copy link
Collaborator

@cniackz cniackz commented Apr 9, 2022

We need to properly test operatorapi instead of restapi:

Screen Shot 2022-04-09 at 10 03 48 AM

I found this issue while adding a new test and looking at the coverage output in the html file.
We were touching restapi but we should be touching operatorapi instead; so I will correct that even if the coverage get decreased because we need to include all go packages not only restapi package.

Coverage

-          threshold=54.00
+          threshold=35.20

This is because 54.00 comes from restapi only, while 35.20 is the union of restapi & operatorapi

@cniackz cniackz added the WIP This PR is WIP and cannot be merged yet label Apr 9, 2022
@cniackz cniackz self-assigned this Apr 9, 2022
@cniackz cniackz changed the title [WIP] - Correcting the testing package in Operator API Tests Correcting the testing package in Operator API Tests Apr 10, 2022
@cniackz cniackz removed the WIP This PR is WIP and cannot be merged yet label Apr 10, 2022
@cniackz cniackz added the operator Operator Console label Apr 10, 2022
@dvaldivia dvaldivia merged commit e9cc567 into minio:master Apr 11, 2022
@cniackz cniackz deleted the increase-code-coverage-sat-apr-9 branch April 11, 2022 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

operator Operator Console

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants