Skip to content

Adding test to cover registerAdminArnsHandlers() #1835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dvaldivia merged 2 commits into from
Apr 13, 2022
Merged

Adding test to cover registerAdminArnsHandlers() #1835

dvaldivia merged 2 commits into from
Apr 13, 2022

Conversation

@cniackz
Copy link
Collaborator

@cniackz cniackz commented Apr 13, 2022 •
edited
Loading

Test to cover registerAdminArnsHandlers()

Before:
Screen Shot 2022-04-12 at 8 14 21 PM

After:
Screen Shot 2022-04-12 at 8 14 07 PM

@cniackz cniackz self-assigned this Apr 13, 2022
@cniackz cniackz added the enhancement New feature or request label Apr 13, 2022
@cniackz cniackz changed the title [WIP] - Adding test to cover registerAdminArnsHandlers() Adding test to cover registerAdminArnsHandlers() Apr 13, 2022
prakashsvmx
prakashsvmx approved these changes Apr 13, 2022
View reviewed changes
Copy link
Member

@prakashsvmx prakashsvmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dvaldivia dvaldivia merged commit 5e10719 into minio:master Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dvaldivia dvaldivia dvaldivia approved these changes

@prakashsvmx prakashsvmx prakashsvmx approved these changes

@jinapurapu jinapurapu Awaiting requested review from jinapurapu

@adfost adfost Awaiting requested review from adfost

@Alevsk Alevsk Awaiting requested review from Alevsk

@bexsoft bexsoft Awaiting requested review from bexsoft

@harshavardhana harshavardhana Awaiting requested review from harshavardhana

@kaankabalak kaankabalak Awaiting requested review from kaankabalak

Assignees

@cniackz cniackz

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cniackz @dvaldivia @prakashsvmx