This repository was archived by the owner on Apr 8, 2022. It is now read-only.
staking functional tests: expect exception on testing failed transactions#135
Merged
staking functional tests: expect exception on testing failed transactions#135
Conversation
b-yap
requested review from
TheQuantumPhysicist,
erubboli,
iljakuklic,
muursh and
zorvan
as code owners
sinitcin
approved these changes
Nov 22, 2021
muursh
approved these changes
Nov 22, 2021
TheQuantumPhysicist
approved these changes
Nov 22, 2021
iljakuklic
approved these changes
Nov 23, 2021
Contributor
|
I think the tests may still fail because programmable pool tests send two invalid transactions to verify that the smart contract is not accepted and those asserts are not addressed in this PR. If people are OK with it, it may be easier to just disable smart contract tests in this PR and once this is merged, I can send a PR that properly fixes the PP tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
also fixing transaction with fee exceeding
u64::MAX