The new version of Tokens by sinitcin · Pull Request #82 · mintlayer/core

sinitcin · 2021-10-28T13:02:55Z

According to #67 the format of the token was changed.

Old functions for creating and sending a token were removed due to we cannot sign transactions on the node side, all transactions must be created and signed on the wallet side. In this version, we only verify is tx correct or not.

Now we have an additional data field that is optional. This field using for:

Token transferring
Token issuance
Token burn (not tested yet).
NFT mint (tested weakly).

Additional unit and functional tests will make later in another PR.

Also, we have not finished yet discussed fixing the verification function, but decided that return here after the test-net: #81
Unfortunately, we have a bunch of cycles there but it works correctly.

UPDATE: NFT will appear in the next PR ❗❗❗

Signed-off-by: sinitcin <antony@email.su>

…into StorageMap Signed-off-by: sinitcin <antony@email.su>

Signed-off-by: sinitcin <antony@email.su> # Conflicts: # pallets/utxo/src/lib.rs # pallets/utxo/src/tests.rs

Signed-off-by: sinitcin <antony@email.su>

…PointerToIssueToken Signed-off-by: sinitcin <antony@email.su>

…now is an OptionQuery. Signed-off-by: sinitcin <antony@email.su>

Signed-off-by: sinitcin <antony@email.su>

…ollect_result functions Signed-off-by: sinitcin <antony@email.su>

Signed-off-by: sinitcin <antony@email.su>

Signed-off-by: sinitcin <antony@email.su> # Conflicts: # .gitignore # pallets/utxo/src/lib.rs # pallets/utxo/src/tests.rs

Signed-off-by: sinitcin <antony@email.su>

Signed-off-by: sinitcin <antony@email.su> # Conflicts: # pallets/utxo/src/lib.rs

Signed-off-by: sinitcin <antony@email.su>

pallets/utxo/src/base58_nostd.rs

pallets/utxo/src/tokens.rs

pallets/utxo/src/verifier.rs

pallets/utxo/src/tests.rs

TheQuantumPhysicist · 2021-11-06T11:21:47Z

Good job. We're getting much closer to what tokens should look like. I think generally the PR is OK. Just a few more tests and the other few comments I mentioned and we're probably good to merge.

muursh · 2021-11-06T16:12:22Z

Agreed with Sam, although in all honesty I've not been through in as much detail as I'd like and I haven't been able to run it for obvious reasons. I think we're close.

…m our functional tests. Signed-off-by: sinitcin <antony@email.su>

Signed-off-by: sinitcin <antony@email.su>

…ypes and readme

sinitcin · 2021-11-07T14:30:10Z

It seems that I have done @muursh @TheQuantumPhysicist

Signed-off-by: sinitcin <antony@email.su>

pallets/utxo/src/tests.rs

…ect to tokens tests. Signed-off-by: sinitcin <antony@email.su>

Signed-off-by: sinitcin <antony@email.su> # Conflicts: # node/src/chain_spec.rs # pallets/utxo/README.md # pallets/utxo/src/lib.rs # pallets/utxo/src/mock.rs # pallets/utxo/src/tests.rs # runtime/Cargo.toml

Signed-off-by: sinitcin <antony@email.su>

rewards_and_staking: fix `non_mlt_staking()` test case

Signed-off-by: sinitcin <antony@email.su>

rewards_and_staking: fix the issue of exceeding u64 value of transaction fee

sinitcin added 23 commits October 1, 2021 01:09

Removed the old header.rs, now TxOutputHeader turn into Enum

89effd9

Added possibility to create a NFT, and removed old TxHeader

f42ac62

Signed-off-by: sinitcin <antony@email.su>

RPC for reading a NFT has been added

aad0bc3

Signed-off-by: sinitcin <antony@email.su>

Fixed compilation error

9a10db2

Signed-off-by: sinitcin <antony@email.su>

Fixed test

7e0cd95

Signed-off-by: sinitcin <antony@email.su>

Added serialization of fields that related to NFT

9441a76

Signed-off-by: sinitcin <antony@email.su>

Removed unwraps from sr25519_sign fn

b3d4247

Signed-off-by: sinitcin <antony@email.su>

Removed RPC calls tokens_list and nft_read. TokenList now turned …

847bf4d

…into StorageMap Signed-off-by: sinitcin <antony@email.su>

Merge remote-tracking branch 'origin/staging' into nft

7e3afd1

Signed-off-by: sinitcin <antony@email.su> # Conflicts: # pallets/utxo/src/lib.rs # pallets/utxo/src/tests.rs

Merge remote-tracking branch 'origin/staging' into nft

fa89a24

Signed-off-by: sinitcin <antony@email.su> # Conflicts: # pallets/utxo/src/lib.rs # pallets/utxo/src/tests.rs

Added the new data field

1a77c9c

Signed-off-by: sinitcin <antony@email.su>

I've been making refactoring, removed TokenList, added a new storage …

717600c

…PointerToIssueToken Signed-off-by: sinitcin <antony@email.su>

Added draft of TransactionVerifier. Value in the PointerToIssueToken …

216a5ee

…now is an OptionQuery. Signed-off-by: sinitcin <antony@email.su>

We need to make an approach to verification

e0e22e4

Signed-off-by: sinitcin <antony@email.su>

Added the first test for tokens - checking_tokens_issuance

eb2d6d3

Signed-off-by: sinitcin <antony@email.su>

Added checking for signature and for tokens amount.

dfecda3

Signed-off-by: sinitcin <antony@email.su>

Added a couple a token creation tests. Added calculating_reward amd c…

7a6d68b

…ollect_result functions Signed-off-by: sinitcin <antony@email.su>

Added a few new tests for token creation, transferring, and minting nft

8fb97b7

Signed-off-by: sinitcin <antony@email.su>

Changed std::convert::TryFrom to sp_std.

958573a

Signed-off-by: sinitcin <antony@email.su>

Merge remote-tracking branch 'origin/timelock' into nft

edd65e3

Signed-off-by: sinitcin <antony@email.su> # Conflicts: # .gitignore # pallets/utxo/src/lib.rs # pallets/utxo/src/tests.rs

Fixed conflicts after merge

4abe164

Signed-off-by: sinitcin <antony@email.su>

Merge remote-tracking branch 'origin/staging' into nft

af752d0

Signed-off-by: sinitcin <antony@email.su> # Conflicts: # pallets/utxo/src/lib.rs

Cleaned up comments

96f73fb

Signed-off-by: sinitcin <antony@email.su>

sinitcin requested review from TheQuantumPhysicist, altonen, iljakuklic and muursh and removed request for altonen October 28, 2021 13:03

altonen reviewed Oct 28, 2021

View reviewed changes

TheQuantumPhysicist reviewed Nov 6, 2021

View reviewed changes

pallets/utxo/src/tests.rs Outdated Show resolved Hide resolved

TheQuantumPhysicist reviewed Nov 6, 2021

View reviewed changes

pallets/utxo/src/tests.rs Show resolved Hide resolved

TheQuantumPhysicist reviewed Nov 6, 2021

View reviewed changes

pallets/utxo/src/tests.rs Show resolved Hide resolved

sinitcin added 5 commits November 7, 2021 12:55

Added more tests for b58 include external data and data generated fro…

4842067

…m our functional tests. Signed-off-by: sinitcin <antony@email.su>

Returned lost comment about race conditions

fd3f582

Signed-off-by: sinitcin <antony@email.su>

Added a new test: test_transfer_and_issuance_in_one_tx.

806f42e

Signed-off-by: sinitcin <antony@email.su>

Fixed types for the UI in utxo Readme.

ead1b52

Signed-off-by: sinitcin <antony@email.su>

Added a new test: test_transfer_for_multiple_tokens. Changed custom-t…

4048d12

…ypes and readme

Merge remote-tracking branch 'origin/staging' into nft

4fd736f

Signed-off-by: sinitcin <antony@email.su>

TheQuantumPhysicist reviewed Nov 7, 2021

View reviewed changes

pallets/utxo/src/tests.rs Outdated Show resolved Hide resolved

sinitcin and others added 13 commits November 8, 2021 12:32

Fixed tests, now position of checks in validation function do not aff…

00aa8c5

…ect to tokens tests. Signed-off-by: sinitcin <antony@email.su>

Merge remote-tracking branch 'origin/staging' into nft

8c74ab2

Signed-off-by: sinitcin <antony@email.su> # Conflicts: # node/src/chain_spec.rs # pallets/utxo/README.md # pallets/utxo/src/lib.rs # pallets/utxo/src/mock.rs # pallets/utxo/src/tests.rs # runtime/Cargo.toml

Fixed after merg with Carla's code

4af552b

Signed-off-by: sinitcin <antony@email.su>

rewards_and_staking: fix non_mlt_staking() test case

953a1c7

Merge pull request #97 from mintlayer/mft_fix_staking_test

b109e27

rewards_and_staking: fix `non_mlt_staking()` test case

Fixed test_reward

4803ffa

Signed-off-by: sinitcin <antony@email.su>

Fixed unit tests after increasing genesis value for accounts

9ecbb44

Signed-off-by: sinitcin <antony@email.su>

Fixed Carla's functional tests

0ca12d9

Signed-off-by: sinitcin <antony@email.su>

Fixed a few more functional tests

bd41c31

Signed-off-by: sinitcin <antony@email.su>

Fixed one more functional test

4985d7b

Signed-off-by: sinitcin <antony@email.su>

Stuck on broken test feature_staking_first_time.py

d7e2e7a

Signed-off-by: sinitcin <antony@email.su>

rewards_staking: fix the issue of exceeding u64 value of transaction fee

4d258e6

Merge pull request #100 from mintlayer/nft_fix_functional_test

5d38367

rewards_and_staking: fix the issue of exceeding u64 value of transaction fee

TheQuantumPhysicist self-requested a review November 9, 2021 07:26

TheQuantumPhysicist approved these changes Nov 9, 2021

View reviewed changes

TheQuantumPhysicist merged commit 798eb8d into staging Nov 9, 2021

TheQuantumPhysicist deleted the nft branch November 9, 2021 07:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

The new version of Tokens#82

The new version of Tokens#82
TheQuantumPhysicist merged 61 commits intostagingfrom
nft

sinitcin commented Oct 28, 2021 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TheQuantumPhysicist commented Nov 6, 2021

Uh oh!

muursh commented Nov 6, 2021

Uh oh!

sinitcin commented Nov 7, 2021

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

sinitcin commented Oct 28, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TheQuantumPhysicist commented Nov 6, 2021

Uh oh!

muursh commented Nov 6, 2021

Uh oh!

sinitcin commented Nov 7, 2021

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

sinitcin commented Oct 28, 2021 •

edited

Loading