Create test for the mint-project#11
Draft
sumwmer wants to merge 5 commits intomintproject:masterfrom
sumwmer:xinting-pytest
Draft
Create test for the mint-project#11sumwmer wants to merge 5 commits intomintproject:masterfrom sumwmer:xinting-pytest
sumwmer wants to merge 5 commits intomintproject:masterfrom
sumwmer:xinting-pytest
Conversation
parametrized check cli unit test for cli using Python Mock ready to rebase
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
THIS PR REQUIRES MORE DISCUSSION
Long term goal: use CI tools to sanity-check on every Git push -> lots of overhead and we don't have a server yet
Short term solution: create a dev docker image (or do pip install pytest in existing docker container) and manually run tests before push?
Current testing structure is simple (since the functionalities are limited). In the future when we have a server & web UI, we should create unit tests for all endpoints and snapshots/selenium for frontend.