Open
Conversation
|
Looks interesting |
18cd18a to
28d8373
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'd like to propose the following changes to support more interactions with the library.
Motivation
I like the idea of sharing permissions using ember-can abilities but I would like to be able to be able to get more data from my abilities. For example I would like to be able to get a reason as to why an ability comes out negative.
Proposal
Given the following ability :
I would still be able to get my ability's value using can and cannot helpers but could also use an helper to get the value of the ability instead of a boolean :
This helper would also support a way that would allow me to get the specific subproperty of the ability in question :