- Updated to 1.0.0 (Baba's Best)#43
Open
Bababooie42 wants to merge 9 commits intomircearoata:masterfrom
Open
Conversation
…noclip; added resist commands; fly state now saves properly per player, no clip state is saved, resists are saved; message handling overhauled; extra mod configs. Probably more.
… command, finalised most changes
… the system message; made sure FoW settings are synced across clients
…rrent and available flyspeeds, made current fly speed display on activation
… didn't think to remove it, but that's been done now - It seemed convoluted to have the command handler send a message to the listener to send a message back to the handler when the listening and handling can all be done on the handler itself with no down time; the listener actor is now a "command handler"-handler - Repeat Command if for when the player is using a toggleable command frequently or simply wants the same command again without typing it all out; people had wanted a way to "go back" through chat history using the up arrow like the console does to reuse commands, and I figured this was an adequate compromise - You're absolutely right about the fog data; I've moved the functions to Util and only perform the setup if the arrays are empty (i.e. haven't been saved with the new values, which should only be on the first time it's created) - Session settings were from earlier testing and are indeed not used anymore at all; I've now removed that deprecated testing function - Agreed on separate commands for FoW; that's now how it is - Resists spaghetti cleaned up, damage types now in an array - Disabling flying will now also disable noclip - If I can find another way to guarantee flying/noclip/etc work properly on servers I can try it but I feel that considering how well it now works, the edge cases as a caveat are worth it and should be able to be easily worked around - Num Messages and History are already only set on clients or solo (they follow after on the false branch of an isDedicatedServer check); each player should only be updating their own settings when they load in or change their own config as far as I'm aware - Removed the redundant addextra0 function and now use the ToText (Integer) - Deprecated code removed
… this, and is now working as intended
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lots of tweaks and additions, namely: fixed fly, noclip; added resist commands; fly state now saves properly per player, no clip state is saved, resists are saved; message handling overhauled; extra mod configs. Probably more.