Skip to content

Package Tests#17

Open
jssotomdz wants to merge 2 commits intokinetic-v6.0.107from
jssotomdz/packagetests
Open

Package Tests#17
jssotomdz wants to merge 2 commits intokinetic-v6.0.107from
jssotomdz/packagetests

Conversation

@jssotomdz
Copy link
Collaborator

Tests checking builds with sln commands and nuget commands

@jssotomdz jssotomdz requested a review from mirespace August 2, 2022 15:05
@mirespace
Copy link
Owner

mirespace commented Aug 5, 2022

Hi Jesús,

The tests seem OK, but unfortunately, we are facing this also when running the autopkgtest. So we are going to wait for a clear run before merging it. In the meantime, we use it manually in the SRU process (thanks for your work!).

On the other hand, as per our conversation, please give some thought to the fusion of basic-sln with basic-commands to minimize the number of tests that running the same commands, and if you are convinced feel free to refactor it. I'll do this way for the manually testing on the SRU process.

@jssotomdz
Copy link
Collaborator Author

Hi Jesús,

The tests seem OK, but unfortunately, we are facing this also when running the autopkgtest. So we are going to wait for a clear run before merging it. In the meantime, we use it manually in the SRU process (thanks for your work!).

On the other hand, as per our conversation, please give some thought to the fusion of basic-sln with basic-commands to minimize the number of tests that running the same commands, and if you are convinced feel free to refactor it. I'll do this way for the manually testing on the SRU process.

Pushed a passing refactor for the basic-commands test so we can save the basic-sln test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants