update from main, add rules fixes and /timeline/ url support#74
Merged
Conversation
…ead (webrecorder#767) * Bump wombat to 3.3.9 * Set target attributes to iframe name
- dependencies: wombat 3.3.11 - ci: pypi publish for pywb - update CHANGES for 2.6.9 release
- use rollup to build vue ui, build at vue/vueui.js - calendar page renders via both /*/ and /*? queries - banner support for framed mode only for now - ensure banner updated in response to inner frame events - combine cdxquery classes into vue build, expose single entrypoint VueUI.main - initial set of vueui dev, calendar, banner, calendar hover mode - ensure embedded mode replay is working - config: rename ui vars to 'vue_calendar_ui' and 'vue_timeline_banner' - dependencies: update to wombat 3.3.6 - bump to 2.7.0b0
- add ui-overview as UI toc page - refactor ui-customization to top-level customizations page - add template-guide for in-depth template reference - add new-vue-ui page for docs on new ui, with images - fix adding logo to old ui, add to docs
* Fix typos. * Make ui variable available to collection page
templates: add placeholder templates (footer.html, head.html) templates: allow 'base_html', 'footer_html', 'head_html', 'header_html' to be added via wb-manager 'add-template' cmd ui: fix logo path, support linking ui: make url on banner an input field docs: clarify docs around templates, paths
- support for 'cdx-simulator' - add loading spinner
- add localized text to frame_insert.html and query.html (for now) to be passed to vueui
- ensure all vue strings localized
- use variable names in localizabls strings, eg. "view capture on {date}"
- simplified text (no cardinal suffixes, use 24-hourt clock)
- make calendar tooltips into real links and clickable and ctrl+clickable
- ensure advanced view uses old ui (not supported in new ui)
- add language popup on frame_insert for vueui
- i18n: consolidate loc strings for vueui into vue_loc.html
- spinner: for replay, only show over banner
- spinner: show after 500ms delay
- i18n: add one more string ('no captures')
- make calendar popup links regular links to support cmd+click
- i18n: implement lang switcher in vue as well (for query and framed_insert), don't include non-vue language switcher in header
Connected to webrecorder#717 When a user navigated to a new URL by clicking on a link in the replay iframe, the new Vue app was unnecessarily triggering a reload, causing what looks like a flash of the page content. This commit modifies the Vue app to only reload the iframe if a user selected a new snapshot from the calendar or timeline.
- Make Vue banner responsive with Bootstrap 4 - Add previous/next year arrows to calendar - Make navbar background, text color, and button outlines configurable via config.yaml - Toggle calendar and timeline separately - Fix bug preventing title from displaying - Make app keyboard-navigable - Fix banner background color configuration - Comment out vue_navbar_background_hash - Display linear timeline tooltip centrally on enter - Improve header styling on small screens - Add titles to font awesome icons - Remove old default banner (calendar retained for advanced search results) - Fix TimelineLinear TypeError that broke calendar - Bump version to 2.7.0b2 - Set Cache-Control header on CDXJ API response to mark returned CDX as stale after 1 day - Add commented out UI values to config.yaml to aid users - Remove timeline and calendar card borders - Fix issues with snapshot navigation - Center search bar and align with buttons - Make Vue app bfcache-ineligible: By adding an empty unload event listener, we make pages serving the Vue app ineligible for bfcache, which prevents unexpected behavior when navigating via the browser's back/forward buttons.
wombat: bump to latest wombat 3.3.7 add new custom_banner to head_insert template for frameless replay
- Add URL search bar title and aria-label - Ensure WCAG AA-acceptable contrast in calendar
- Add thorough Vue theming instructions - Update frameless replay banner info
Use old results view if matchType or filter params are present in query string.
- Remove redundant icon title - Fix display date in TimelineLinear tooltip - Adjust calendar spacing, add border and shadow - Remove tooltip scroll - Auto-size calendar to contents - Make display date consistent across browsers - Render calendar for all months regardless of captures - Fix weekday labels to avoid off-by-one - Grey out calendar days without captures
substituion functionality already exists on a global level for matched rules but this causes issues when rule sets conflict in the desired outcome. This change enables setting regex substitution at the rule level to avoid these conflicts.
* Add locale-dependent handling of first day of week The Intl.Locale is a proposed standard not yet supported by Firefox so in Firefox the first day of week will default to Monday (as specified in ISO-8601). * Set top frame document title when Vue updates * Update template guide for 2.7 * Drop Python 3.6 and add 3.10 in test CI * Allow either JS mimetype in test_add_static * Add convenience build script for Vue UI * Add build flag to docker compose example * Fix Vue app issue with redirect_to_exact: false Fixes webrecorder#779 Undated URLs were resulting in a broken calendar and timeline in the Vue app when redirect_to_exact was set to false. This was due to TopFrameView using the current datetime if no timestamp was included, which caused a failed snapshot lookup in the Vue app. This commit changes the default timestamp in TopFrameView to None and adds additional logic in the Vue app to use the last snapshot's timestamp as the default if one is not present to match the snapshot that pywb loads by default under the same conditions. * Add filter instead of submitting form when pressing enter in the filtering expression field * Make filter expressions translatable * Add missing tooltip strings to vue_loc * Add changelog * Bump version to 2.7.1 * Use empty string as default template timestamp * Bump wombat to 3.3.13 Co-authored-by: Jonas Linde <jonasjlinde@gmail.com>
* Fix 2.7.1 regressions * Bump to 2.7.2 * fix redirect-to-exact false: - check if current loaded timestamp is the same as to-redirected to timestamp, and avoid reload * additional ui fixes: - location bar: reload with current timestamp, instead of going to calendar - ensure calendar popup on replay view is scrollable - 'Live' mode fixes: don't cache live cdx entry, don't add timestamp when navigating in live mode without timestamp - remember timeline view toggle on replay - title: add 'Archived Page: ' prefix to document.title, consistent with old version - ensure 'Archived Page: ' text is localizable - ui: change ',' to '|' on capture display * update CHANGES for 2.7.2 Co-authored-by: Ilya Kreymer <ikreymer@gmail.com>
* Add ui.logo_home_url as config option * Add ui.logo_home_url to docs
* Add date-range feedback for i18n * Make search page more intuitive and add help text * Add a clear-options button to the search page
* Modify search page button colors * Rename Clear Options to Reset and reset URL as well * Add search improvements to CHANGES
Update from main
feat: regex substitution on surt rules match
fix: regex replace fixes
Member
Author
|
Example of /timeline/ used in the query page url.
|
mijho
approved these changes
Jan 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for /timeline/ urls in addition to /*/
It also adds fixes to allow rules.yaml to work with additional filters