If You run a filter against the live service to only show certain sta…#77
Merged
If You run a filter against the live service to only show certain sta…#77
Conversation
…tus codes and there are no results for that filter, PYWB will attempt to ditch your filter and just return the first 100 results it has for that URL. So, by default PYWB will try to get all 2xx and 3xx results. If none exist, it will then give you 100 4xx and 5xx results it has for that URL. I've changed the logic to not do the extra return if filters are supplied to the query. I need this to be tested extensively and confirmed non-destructive before we merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…tus codes and there are no results for that filter, PYWB will attempt to ditch your filter and just return the first 100 results it has for that URL.
So, by default PYWB will try to get all 2xx and 3xx results. If none exist, it will then give you 100 4xx and 5xx results it has for that URL.
I've changed the logic to not do the extra return if filters are supplied to the query. I need this to be tested extensively and confirmed non-destructive before we merge.
Description
Motivation and Context
Screenshots (if appropriate):
Types of changes
Checklist: