Conversation
I've added the base functionality in PyWB to control the different permutations of toggles:
# a single digit end_timestamp controls the timeline filters
# <empty> - show one capture per day, and hide redirects
# 1 - show one capture per day, and show redirects
# 2 - show all captures, and hide redirects
# 3 - show all captures, and show redirects
These utilise the current `end_timestamp` regex parameter of `WbUrl`'s `QUERY_REGEX`:
QUERY_REGEX = re.compile('^(?:([\w\-:]+)/)?(\d*)(timeline|[*-])(\d*)/?(.+)$')
This means that URLs with the various filters applied will have a single digit numeric suffix to "timeline", such as:
http://0.0.0.0:8080/ukgwa/timeline/www.gov.uk
http://0.0.0.0:8080/ukgwa/timeline1/www.gov.uk
http://0.0.0.0:8080/ukgwa/timeline2/www.gov.uk
http://0.0.0.0:8080/ukgwa/timeline3/www.gov.uk
mijho
reviewed
May 8, 2024
mijho
left a comment
There was a problem hiding this comment.
@KarlXerri this looks good to me but as we discussed the other day in person I imagine that TNA will want to change the terms we use to specify the different options. Let's get it out in front of them and get some feedback
mijho
approved these changes
May 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added the base functionality in PyWB to control the different permutations of toggles:
a single digit end_timestamp controls the timeline filters
These utilise the current
end_timestampregex parameter ofWbUrl'sQUERY_REGEX: QUERY_REGEX = re.compile('^(?:([\w-:]+)/)?(\d*)(timeline|[-])(\d)/?(.+)$')This means that URLs with the various filters applied will have a single digit numeric suffix to "timeline", such as:
http://0.0.0.0:8080/ukgwa/timeline/www.gov.uk
http://0.0.0.0:8080/ukgwa/timeline1/www.gov.uk
http://0.0.0.0:8080/ukgwa/timeline2/www.gov.uk
http://0.0.0.0:8080/ukgwa/timeline3/www.gov.uk
Description
Motivation and Context
Screenshots (if appropriate):
Types of changes
Checklist: