modifications while getting the weighting working#1
Merged
mirzaees merged 5 commits intoMar 13, 2024
Merged
Conversation
The last implementation had a default of 0.0 Since every weight was >=0, no pixels were interpolated.
|
Hi @scottstanie thanks for all the fixes and I agree with you I think having the thresh cor parameter its useful, I would expect having to modify it for cases where the interferogram has very bad coherence or very good. |
mirzaees
approved these changes
Mar 13, 2024
mirzaees
reviewed
Mar 13, 2024
Owner
mirzaees
left a comment
mirzaees
left a comment
There was a problem hiding this comment.
Thank you @scottstanie and @taliboliver
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Big fix was the
>=0default which led to no interpolation for 0/1 weights.I also removed the
Binary weightlogging check, since it seemed like an expensive operation just for logging.I added the cor threshold as a parameter since it seemed like a sensitive knob to me... but @taliboliver would know better as one who's testing more