Hidden feature reappears on apply call

[rsupnekar]

It is not clear if this is an EMP issue. However, it has been added for tracking. The description below is from an email I received.

I'm working on a bug fix ticket for map and had a question about how emp is handling feature.apply().

Currently when we add a feature to the map a thread is spawned on a delayed timer to set the currency (fade). After a set amount of time the feature is supposed to look faded by setting the alpha level. This works just fine. The problem comes in when we have a feature that is "hidden" (from calling map.setVisibility on the feature), the currency timer counts down, sets the alpha level to the proper setting, and calls feature.apply(). The apply() causes the symbol to appear on the map despite having a visibility setting of isHidden. From the log I can see the visibility set to what I expect it to be. Is this a fix that can be done in EMP?

[rsupnekar]

I commented out my 'feature.apply()' and the symbol did NOT reappear.

To give you a bit more back ground the following two methods are what is executed when a currency timeout occurs for a particular feature. This is done on a background thread from a handler. The import piece to see in the first method is we are using the global.findFeature to get the feature.
long setCurrencyFromTimeDelta(UUID featureId){
long deltaTime = 0;
IFeature feature = global.findFeature(featureId);
//if the symbol is a milstdsymbol and is single point
//only then do we apply currency
if(feature != null && feature instanceof MilStdSymbol) {
if(((MilStdSymbol) feature).isSinglePoint()) {
deltaTime = getDeltaTime(featureId);
if(deltaTime != -1) {
setCurrencyFromTimeDelta(feature, deltaTime);
}
}
}

return deltaTime;

}

void setCurrencyFromTimeDelta(IFeature feature, long deltaTime){

IGeoFillStyle featureFillStyle = feature.getFillStyle();
IGeoColor featureColor = null;
if(featureFillStyle == null){

    featureFillStyle = new GeoFillStyle();
    featureColor = featureFillStyle.getFillColor();
    Color affiliationColor = SymbolUtilities.getFillColorOfAffiliation(((MilStdSymbol) feature).getSymbolCode());
    featureColor.setRed(affiliationColor.getRed());
    featureColor.setGreen(affiliationColor.getGreen());
    featureColor.setBlue(affiliationColor.getBlue());
}else {
    featureColor = featureFillStyle.getFillColor();
}

if(deltaTime >= oldStateTimeout) {
    featureColor.setAlpha(.25);
} else if(deltaTime >= staleStateTimeout){
    featureColor.setAlpha(.5);
    setCurrencyTimer(feature.getGeoId().toString(), deltaTime);
} else {
    featureColor.setAlpha(1);
    setCurrencyTimer(feature.getGeoId().toString(), deltaTime);
}
featureFillStyle.setFillColor(featureColor);
feature.setFillStyle(featureFillStyle);

feature.apply();

}
Setting the visibility takes place in a separate place. Smart filter appear as layers in the 'Pictures' pull out drawer from the left. If you uncheck a smart filter, say Friendly, it will hide all friendly features on the map with this command. This does work and the feature is no longer visible.
map.setVisibility(feature.getGeoId(), VisibilityActionEnum.HIDE_ALL);
One thing I did try was commenting out the feature.apply() from the second method and then run through the same procedure to get the currency to trigger. The feature remained hidden.

[rsupnekar]

Turned out all MilStdSymbol single point features were being updated when the renderer was kicked off