Skip to content

Conversation

@renovate
Copy link
Contributor

@renovate renovate bot commented May 25, 2025

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@fastify/cors 10.1.0 -> 11.0.1 age adoption passing confidence
@fastify/http-proxy 10.0.2 -> 11.1.2 age adoption passing confidence
@fastify/view 10.0.2 -> 11.1.0 age adoption passing confidence
@nestjs/platform-express (source) 10.4.17 -> 11.1.2 age adoption passing confidence
@sentry/node (source) 8.55.0 -> 9.22.0 age adoption passing confidence
@sentry/profiling-node (source) 8.55.0 -> 9.22.0 age adoption passing confidence
@simplewebauthn/server (source) 12.0.0 -> 13.1.1 age adoption passing confidence
@sinonjs/fake-timers 11.3.1 -> 14.0.0 age adoption passing confidence
@smithy/node-http-handler (source) 2.5.0 -> 4.0.5 age adoption passing confidence
@twemoji/parser 15.1.1 -> 16.0.0 age adoption passing confidence
@​types/bcryptjs 2.4.6 -> 3.0.0 age adoption passing confidence
@types/ms (source) 0.7.34 -> 2.1.0 age adoption passing confidence
bcryptjs 2.4.3 -> 3.0.2 age adoption passing confidence
body-parser 1.20.3 -> 2.2.0 age adoption passing confidence
cbor (source) 9.0.2 -> 10.0.3 age adoption passing confidence
color-convert 2.0.1 -> 3.1.0 age adoption passing confidence
date-fns 2.30.0 -> 4.1.0 age adoption passing confidence
execa 8.0.1 -> 9.6.0 age adoption passing confidence
feed 4.2.2 -> 5.0.1 age adoption passing confidence
file-type 19.6.0 -> 21.0.0 age adoption passing confidence
happy-dom 16.8.1 -> 17.4.7 age adoption passing confidence
is-svg 5.1.0 -> 6.0.0 age adoption passing confidence
mime-types 2.1.35 -> 3.0.1 age adoption passing confidence
nodemailer (source) 6.10.1 -> 7.0.3 age adoption passing confidence
pkce-challenge 4.1.0 -> 5.0.0 age adoption passing confidence
redis-lock 0.1.4 -> 1.0.0 age adoption passing confidence
secure-json-parse 3.0.2 -> 4.0.0 age adoption passing confidence
ulid 2.4.0 -> 3.0.0 age adoption passing confidence

Release Notes

fastify/fastify-cors (@​fastify/cors)

v11.0.1

Compare Source

What's Changed

New Contributors

Full Changelog: fastify/fastify-cors@v11.0.0...v11.0.1

v11.0.0

Compare Source

Breaking Change

In order to provides safer default, we change the methods to the CORS-safelisted methods.
If you want to resume the previous behaviour, you need to explicitly specify the methods,

import Fastify from 'fastify'
import cors from '@​fastify/cors'

const fastify = Fastify()
await fastify.register(cors, {
  methods: "GET,HEAD,PUT,PATCH,POST,DELETE"
})

What's Changed

Full Changelog: fastify/fastify-cors@v10.1.0...v11.0.0

fastify/fastify-http-proxy (@​fastify/http-proxy)

v11.1.2

Compare Source

v11.1.1

Compare Source

What's Changed

Full Changelog: fastify/fastify-http-proxy@v11.1.0...v11.1.1

v11.1.0

Compare Source

What's Changed

New Contributors

Full Changelog: fastify/fastify-http-proxy@v11.0.1...v11.1.0

v11.0.1

Compare Source

What's Changed

Full Changelog: fastify/fastify-http-proxy@v11.0.0...v11.0.1

v11.0.0

Compare Source

What's Changed

Full Changelog: fastify/fastify-http-proxy@v10.0.2...v11.0.0

fastify/point-of-view (@​fastify/view)

v11.1.0

Compare Source

What's Changed

New Contributors

Full Changelog: fastify/point-of-view@v11.0.0...v11.1.0

v11.0.0

Compare Source

What's Changed

New Contributors

Full Changelog: fastify/point-of-view@v10.0.2...v11.0.0

nestjs/nest (@​nestjs/platform-express)

v11.1.2

Compare Source

v11.1.1

Compare Source

v11.1.0

Compare Source

v11.1.0 (2025-04-23)

Enhancements
Committers: 1

v11.0.21

Compare Source

v11.0.21 (2025-04-23)

Enhancements
Dependencies
Committers: 1

v11.0.20

Compare Source

What's Changed
New Contributors

Full Changelog: nestjs/nest@v11.0.19...v11.0.20

v11.0.19

Compare Source

v11.0.18

Compare Source

What's Changed

Full Changelog: nestjs/nest@v11.0.17...v11.0.18

v11.0.17

Compare Source

v11.0.16

Compare Source

v11.0.16 (2025-04-11)

v11.0.15

Compare Source

v11.0.15 (2025-04-10)

Bug fixes
Committers: 1

v11.0.14

Compare Source

v11.0.14 (2025-04-09)

Bug fixes
  • platform-fastify
Committers: 1

v11.0.13

Compare Source

v11.0.13 (2025-04-03)
Bug fixes
  • platform-fastify
  • microservices
    • #​14869 fix(microservices): do not re-create client connection once get client by service name (@​mingo023)
Dependencies
Committers: 2

v11.0.12

Compare Source

v11.0.12 (2025-03-19)

Bug fixes
Enhancements

v11.0.11

Compare Source

v11.0.11 (2025-02-28)

Enhancements
  • platform-fastify
Dependencies
Committers: 1

v11.0.10

Compare Source

v11.0.10 (2025-02-17)

Bug fixes

v11.0.9

Compare Source

v11.0.9 (2025-02-10)

Bug fixes
Committers: 2

v11.0.8

Compare Source

v11.0.8 (2025-02-06)

Bug fixes
Committers: 4

v11.0.7

Compare Source

v11.0.7 (2025-01-31)
Bug fixes
Committers: 1

v11.0.6

Compare Source

v11.0.6 (2025-01-27)

Bug fixes
Committers: 1

v11.0.5

Compare Source

v11.0.5 (2025-01-23)

Bug fixes
Committers: 1

v11.0.4

Compare Source

v11.0.3

Compare Source

v11.0.2

Compare Source

v11.0.1

Compare Source

v11.0.0

Compare Source

v11.0.0 (2025-01-16)

Article: https://trilon.io/blog/announcing-nestjs-11-whats-new
Migration guide: https://docs.nestjs.com/migration-guide 👈 👈 👈

⚠️ Node v16 and v18 are no longer supported (>= v20 is required).

Features
  • common, core, microservices
  • common, core
  • common, core, microservices, platform-express, platform-fastify, platform-socket.io, platform-ws, testing, websockets
    • #​14238 chore(deps): upgrade to express v5, fastify v5, add legacy route path converter to minimize breaking changes (@​kamilmysliwiec)
Enhancements
Bug fixes
Other packages in the ecosystem
Dependencies

Configuration

📅 Schedule: Branch creation - Between 12:00 AM and 12:59 AM ( * 0 * * * ) in timezone Asia/Tokyo, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot added the dependencies Pull requests that update a dependency file label May 25, 2025
@github-actions github-actions bot added the packages/backend Server side specific issue/PR label May 25, 2025
@codecov
Copy link

codecov bot commented May 25, 2025

Codecov Report

❌ Patch coverage is 93.67089% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.53%. Comparing base (81635d9) to head (fc43017).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
packages/backend/src/misc/distributed-lock.ts 85.71% 7 Missing ⚠️
...ges/backend/src/core/activitypub/ApInboxService.ts 57.14% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #16099      +/-   ##
===========================================
- Coverage    45.53%   45.53%   -0.01%     
===========================================
  Files         1794     1793       -1     
  Lines       186731   186767      +36     
  Branches      5576     5583       +7     
===========================================
+ Hits         85035    85048      +13     
- Misses      101656   101691      +35     
+ Partials        40       28      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented May 25, 2025

このPRによるapi.jsonの差分
差分はありません。
Get diff files from Workflow Page

@kakkokari-gtyih
Copy link
Contributor

kakkokari-gtyih commented May 25, 2025

やること

  • undici のバージョンアップで最低nodeバージョンが >=20.18.1 に上がっている。.min-node-version を上げる必要あり?
  • bcryptjs は内部に型定義が含まれるようになったので @types/bcryptjs を消す必要あり
  • simplewebauthnattestationType に設定できるオプションが変化したので新しい対応するものに変更する必要あり( update deps #15311 (comment) で残した作業)
  • file-type の型が変わってそう(まだ確認できていない)

@KisaragiEffective
Copy link
Collaborator

#15955

@kakkokari-gtyih kakkokari-gtyih linked an issue May 25, 2025 that may be closed by this pull request
@renovate renovate bot force-pushed the renovate/major-backend-update-dependencies branch from 27a10a1 to df93558 Compare May 26, 2025 06:57
@renovate renovate bot force-pushed the renovate/major-backend-update-dependencies branch from df93558 to 026e989 Compare May 26, 2025 22:50
@KisaragiEffective
Copy link
Collaborator

file-type

sindresorhus/file-type#693 により普通に削除されただけなので import 消すだけっぽさ

@renovate
Copy link
Contributor Author

renovate bot commented May 27, 2025

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

u1-liquid and others added 3 commits May 27, 2025 12:14
- メンテナンスされないredis-lockを自前実装に変更
- 既にロックされている場合のリトライ間隔を調整
@kakkokari-gtyih
Copy link
Contributor

バックエンドのユニットテストが固まって動かない

@kakkokari-gtyih kakkokari-gtyih marked this pull request as draft May 27, 2025 05:56
@syuilo
Copy link
Member

syuilo commented Nov 29, 2025

jsdomとhappy-domは消えた

@kakkokari-gtyih
Copy link
Contributor

jsdomってテストの方で残ってなかったけっけ

@syuilo
Copy link
Member

syuilo commented Nov 29, 2025

あー

@syuilo
Copy link
Member

syuilo commented Nov 29, 2025

テストの方のjsdomも簡単に消せそう

@syuilo
Copy link
Member

syuilo commented Nov 29, 2025

parse5も消せる

@syuilo
Copy link
Member

syuilo commented Nov 29, 2025

消しまくり

@syuilo
Copy link
Member

syuilo commented Nov 29, 2025

入れたい

@syuilo
Copy link
Member

syuilo commented Nov 29, 2025

AppLockService使わなくなった理由なにかしら

@kakkokari-gtyih
Copy link
Contributor

kakkokari-gtyih commented Nov 29, 2025

AppLockService使わなくなった理由なにかしら

redis-lockがかなり長い間(3年~)メンテナンスされていなかったのと、ioが代替の実装をしていたので

MisskeyIO#889 (in 90e2dfe, 70415bd)

@kakkokari-gtyih kakkokari-gtyih added this to the 2025.11.2 milestone Nov 29, 2025
@syuilo
Copy link
Member

syuilo commented Nov 29, 2025

関数に渡すRedisインスタンスが固定っぽいからAppLockServiceで当該関数をラップする方が実装が綺麗そうと思った

@kakkokari-gtyih
Copy link
Contributor

時間あるならしゅいろさんがわでいい感じ™にやってもらえると助かるかもしれない

@syuilo
Copy link
Member

syuilo commented Nov 30, 2025

敢えてそう実装している理由がないのであればやる

@kakkokari-gtyih
Copy link
Contributor

ioからcherry-pickしたので意図は私の知るところではないわね
あとバックエンドにおけるベスト・プラクティスを知らないのでそれが良い実装かどうかもわからない

@kakkokari-gtyih
Copy link
Contributor

もしかしたら将来的に異なるredisを使えるようにそうしてたのかもしれない

@syuilo
Copy link
Member

syuilo commented Nov 30, 2025

まあその場合でもAppLockServiceでラップしていた方が便利そうではある(Redisインスタンスの指定がない場合にデフォルトでDI.redisを使うようにしたりできる)

@syuilo
Copy link
Member

syuilo commented Nov 30, 2025

@copilot いい感じ™にAppLockServiceを復活させてacquireApObjectLockをラップする実装にできますか?

Copy link
Contributor

Copilot AI commented Nov 30, 2025

@syuilo I've opened a new pull request, #16897, to work on those changes. Once the pull request is ready, I'll request review from you.

@syuilo
Copy link
Member

syuilo commented Nov 30, 2025

一旦入れるか

@syuilo syuilo merged commit 0455187 into develop Nov 30, 2025
4 checks passed
@syuilo syuilo deleted the renovate/major-backend-update-dependencies branch November 30, 2025 00:58
@github-project-automation github-project-automation bot moved this from Todo to Done in [実験中] 管理用 Nov 30, 2025
@syuilo
Copy link
Member

syuilo commented Nov 30, 2025

🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file packages/backend:test packages/backend Server side specific issue/PR size:L This PR changes 100-499 lines, ignoring generated files.

Projects

Development

Successfully merging this pull request may close these issues.

types/bcrypt を devDependencies から消す

6 participants