Skip to content

Conversation

@syuilo
Copy link
Member

@syuilo syuilo commented Jan 6, 2026

What

Why

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@codecov
Copy link

codecov bot commented Jan 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.25%. Comparing base (6e99acf) to head (8cce6df).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #17069      +/-   ##
===========================================
- Coverage    63.09%   61.25%   -1.84%     
===========================================
  Files         1152     1152              
  Lines       115196   115196              
  Branches      7976     7661     -315     
===========================================
- Hits         72680    70562    -2118     
- Misses       40369    42465    +2096     
- Partials      2147     2169      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2026

このPRによるapi.jsonの差分
差分はありません。
Get diff files from Workflow Page

@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2026

Backend Memory Usage Comparison

Metric base head Diff
RSS 321.68 MB 299.72 MB -21.96 MB (-6.82%)

See workflow logs for details

@anatawa12
Copy link
Member

anatawa12 commented Jan 6, 2026

minifyする前にhardlinkを解除しないとpnpmのキャッシュを壊しまくって大変なことになる可能性がありそう(未検証だけど仕組み上の考え)

writeFileSyncがdelete + createするかtrancate + writeするかは未定義だと思われるので

@kakkokari-gtyih
Copy link
Contributor

直接node_modulesフォルダをいじるのではなく、こういうのを使ってartifact+node_modulesだけのbuiltディレクトリを作るのでもよさそう(↓ は前試した時うまく動かなかったけど・・・)

https://github.com/unjs/nf3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages/backend Server side specific issue/PR

Projects

Development

Successfully merging this pull request may close these issues.

4 participants