Make lexvar style rules renderer and theme specific #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: Id66fb1132c4016efae333ec7ebe926516f93c697
Member
Author
|
@mark-friedman So the challenge with #51 is that the CSS rules created by the renderer have a higher selectivity than our own rules. This change makes it so that we can have the same selectivity by using the renderer/theme information. However, at that point the Blockly CSS has been injected so we cannot use that API (it just throws an error). To address this, I have the plugin make its own style element to contain its CSS independent of the Blockly CSS. |
mark-friedman
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: Id66fb1132c4016efae333ec7ebe926516f93c697