Remove FieldLexicalVariable.block_ field

[TannerGabriel]

Closes #9

[mark-friedman]

@TannerGabriel Thanks for taking this on! How did you test your changes?

[TannerGabriel]

I tried multiple configurations with the getters and setters, logging and comparing block_ and sourceBlock_ and comparing the results of the dropdown. If I should do some further testing, let me know.

[mark-friedman]

I tried multiple configurations with the getters and setters, logging and comparing block_ and sourceBlock_ and comparing the results of the dropdown. If I should do some further testing, let me know.

When testing various configuration, here are some of the things that I manually test, in the context of some reasonably deeply nested set of definitional and other random blocks. Make sure to have some of the variable definitions shadow other variable definitions (i.e. have the same name). Also include a global variable definition in the workspace:

• get and set blocks show the correct set of variable names in their drop downs at each point in the nested structure.
• Renaming variables correctly renames the get and set blocks within, and only within, their scope.
• Moving a get or set block out of it's scope shows a warning and moving the block back into an appropriate scope removes the warning.

You should also run the unit tests via npn run test

[TannerGabriel]

Thank you for the input. I will manually test a few more configurations tomorrow and get back to you after that.

The unit tests are all passing. Do you think it would be useful to add a small GitHub Action that automatically runs the unit tests for each PR?

[mark-friedman]

Do you think it would be useful to add a small GitHub Action that automatically runs the unit tests for each PR?

That would be great! Thx.

[TannerGabriel]

Sure, I will create a separate PR for that tomorrow.

[TannerGabriel]

Created the PR for the GitHub action #72. Also, manually tested the additional cases you mentioned, which seem to be working fine.