Skip to content

Multi-wallet#59

Merged
adiabat merged 37 commits into
masterfrom
multiwal
May 9, 2017
Merged

Multi-wallet#59
adiabat merged 37 commits into
masterfrom
multiwal

Conversation

@adiabat
Copy link
Copy Markdown
Collaborator

@adiabat adiabat commented May 8, 2017

Tests don't pass as some RPC structures have changed. Will describe the PR and update tests shortly.

Also this is a huge PR and hopefully there won't be more of these; will try to keep mostly in sync with master and perform smaller PRs.

adiabat added 30 commits April 20, 2017 15:56
if only it were that simple
doesn't compile yet
uses default wallet though
network connects but POW check fails (of course)
goes wayyy slower now for header sync.
which makes sense but is not ideal
Merge branch 'master' into multiwal
add cointype to channel description
not sure where that bug was introduced
@adiabat
Copy link
Copy Markdown
Collaborator Author

adiabat commented May 9, 2017

Travis tests are gone for now but manually running test_lit.py mostly works on the lit side, but not the bitcoind side.

the test_lit.py script fails because of control over the bitcoind node. The errors I get are:

Received response from bitcoin node: {"result":null,"error":{"code":-32600,"message":"Params must be an array"},"id":"2645"}

this may be due to a different version of bitcoind, or copying code from the lit and bitcoind rpcs which may work somewhat differently. If it's makes sense, we can change the lit rpc calls to work more like bitcoind, which is more widely known and used.

I think I will merge this change in even with this part of the automated tests not working. This is a fairly big / disruptive change so there will probably be bugs it generates. But I'd rather get it in to master sooner so that everyone else can base their work on it. Will merge this in tomorrow if there aren't any objections.

@adiabat adiabat changed the title [WIP] Multi-wallet Multi-wallet May 9, 2017
@jnewbery
Copy link
Copy Markdown
Contributor

jnewbery commented May 9, 2017

"Params must be an array" tells me your version of bitcoind predates this: bitcoin/bitcoin#8811 , so is pre v0.14.

I'll add a check to the tests to make sure that bitcoin is at version 0.14 or above.

@adiabat
Copy link
Copy Markdown
Collaborator Author

adiabat commented May 9, 2017

Test seems to be failing due to travis / bitcoind errors; it passes on my local machine with bitcoind 0.14.1. Will merge this now so things can be based off it.

@adiabat adiabat merged commit 4b15e2d into master May 9, 2017
delbonis pushed a commit to delbonis/lit that referenced this pull request Jun 19, 2018
* mke SubWallet a []slice!
if only it were that simple

* migrating to multiwallet

doesn't compile yet

* make ls / send / sweep work
uses default wallet though

* fix address creation in litaf

* initial commit
network connects but POW check fails (of course)

* add hardcoded string for litecoin testnet4

* switch name of litecoin testnet4

* switch to bech32 address encoding

* change fees for channels

* wallet address parsing for send / fan / sweep

* specify multiple node hostnames in commandline args

* change derivation paths to use coin type

* add cointype to fund channel rpc / messages

* use scrypt PoW verification

goes wayyy slower now for header sync.
which makes sense but is not ideal

* fix (partial) bech32 address in multiwal

* use flexible segwit addresses

* fix channel funding issues
add cointype to channel description

* fix utxo listing bug

* add cointypes to rpc responses and lit-af

* fix close signature encoding
not sure where that bug was introduced

* fix TestChanDescMsg test

* refactor linkWallets to separate function

* temp allow walletless node for testing

* improve interface for multiple coin types

* switch tests to use privkey.hex instead of testkey.hex

* modify rpc, tests

listen now returns formatted json instead of just a string
for easier parsing.

* change "Bal" to "Balance", increase delays on test timeouts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants