Merged
Conversation
…ubspace_dmdc. still need to test
…simdist, and switch intelligently under the hood (so that users just specify parameters)
…ut initializing (for defaults)
…fig that is passed in , generalize to generalizedDSA as a whole (but with the option to still pass in the class)
Contributor
|
@mitchellostrow I've opened a new pull request, #21, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: mitchellostrow <35669245+mitchellostrow@users.noreply.github.com>
Contributor
|
@mitchellostrow I've opened a new pull request, #22, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: mitchellostrow <35669245+mitchellostrow@users.noreply.github.com>
…-6ce3-4c8a-9f0e-99c7443a6454 Remove unused pad_zeros import from simdist tests
…-43af-463d-98ba-1676ffc421fb Remove unused SimilarityTransformDist import from simdist_controllability
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 55 out of 64 changed files in this pull request and generated 23 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…allable environment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.