This repository was archived by the owner on Jul 31, 2020. It is now read-only.
Change return type for synchronizeState to [IGroup[], IScene[]]#58
Merged
ProbablePrime merged 4 commits intomixer:feature/sync-statefrom Jun 3, 2017
Merged
Conversation
kateract
changed the title
Contributor
|
I'm merging this into my feature branch and then fixing up the tests. Many thanks for your help @kateract |
ProbablePrime
added a commit
that referenced
this pull request
Jun 7, 2017
…groups. (#57) * feat: Add a utility method `synchronizeState` which syncs scenes and groups. A lot of our examples did the same thing as a promise chain, it made sense to create a utility method. * correct comment * Change return type for synchronizeState to [IGroup[], IScene[]] (#58) * add syncScenes * attempt to add tests * merge changes * added trailing comma for linting * spelling * TESTS! * FAILING TESTS D: * Fix endpoint discovery tests * lint * This reads better
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed return type per discussion in #57 , also my (failed) attempt at adding tests for the methods in question per @ProbablePrime