Encapsulate crc16() to avoid global #566
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felipediel
added a commit
to felipediel/python-broadlink
that referenced
this pull request
Apr 26, 2021
felipediel
added a commit
to felipediel/python-broadlink
that referenced
this pull request
Sep 12, 2021
* Rename calculate_crc16 to crc16 * Apply PEP-8 naming conventions * Remove unnecessary import * Accept any sequence type * Remove unnecessary conversions * Expose polynomial and initial value as kwargs * Remove unnecessary bitwise operations * Store the CRC-16 table for performance * Add missing type hints * Update docstring * General improvements Encapsulate crc16() to avoid global (mjg59#566) Segregate CRC16.get_table() from CRC16.calculate() (mjg59#567)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps us to avoid
global, which is usually a code smell.