Skip to content

Conversation

@felipediel
Copy link
Collaborator

@felipediel felipediel commented Oct 18, 2021

Context

In some cases, specially when dealing with multiple network interfaces, it may be necessary to specify a broadcast address in the setup function, or the message will miss the target.

Proposed change

Add ip_address option to setup().

Credits

From: #619. Thanks @IgitBuh!

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New device
  • New product id (the device is already supported with a different id)
  • New feature (which adds functionality to an existing device)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests
  • Documentation

Additional information

Checklist

  • The code change is tested and works locally.
  • The code has been formatted using Black.
  • The code follows the Zen of Python.
  • I am creating the Pull Request against the correct branch.
  • Documentation added/updated.

@felipediel felipediel merged commit b596984 into mjg59:dev Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant