Skip to content

Fix some problems with --durations in the current version. #741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bengtmartensson wants to merge 6 commits into from
Closed

Fix some problems with --durations in the current version. #741

bengtmartensson wants to merge 6 commits into from

Conversation

@bengtmartensson
Copy link
Contributor

@bengtmartensson bengtmartensson commented Jan 13, 2023

Context

Fixes bugs, described in #740.

Proposed change

Changes made to Python: replaced / by //. Changes to the main program: an if.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New device
  • New product id (the device is already supported with a different id)
  • New feature (which adds functionality to an existing device)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests
  • Documentation

Additional information

Checklist

  • The code change is tested and works locally.
  • The code has been formatted using Black.
  • The code follows the Zen of Python. Seriously!!??
  • I am creating the Pull Request against the correct branch.
  • Documentation added/updated.

felipediel and others added 6 commits May 23, 2022 02:35
@felipediel
Merge new product ids into master (mjg59#686)
d5cf63b 
* Add support for Broadlink RM4 mini (0x5216) (mjg59#671)

* Add support for Broadlink RM4 pro 0x520B (mjg59#673)

* Add support for SP4L-UK 0xA569 (mjg59#677)

* Fixing typo in rm4pro device definitions (mjg59#682)

* Add support for Bestcon RM4C pro (0x5218) (mjg59#683)

* Add support for Broadlink RM4 TV mate (0x5212) (mjg59#684)

* Add support for Broadlink RM4 mini (0x520C) (mjg59#685)
@felipediel
Bump version to 0.18.2 (mjg59#687)
a86e9cb
@felipediel
Fix Github actions (mjg59#727)
47b3245 
* Bump checkout to v3 and setup-python to v4

* Remove unused branches

* Fix ubuntu at v20.04
@felipediel
Merge new product ids into master (mjg59#726)
9d5339a 
* Add support for RM4C mini (0x520D) (mjg59#694)

* Add support for SP4L-US (0x648C) (mjg59#707)

* Add support for RM4C mate (0x5211) (mjg59#709)

* Add support for RM4 mini (0x521C) (mjg59#710)

* Add support for LB1 (0x644B) (mjg59#717)
@felipediel
Bump version to 0.18.3 (mjg59#728)
3c183ea
@bengtmartensson
Fix some problems with --durations in the current version.
61e6419 
Resolves mjg59#740.
@bengtmartensson bengtmartensson mentioned this pull request Jan 19, 2023
Closed
13 tasks
@felipediel felipediel mentioned this pull request Apr 11, 2024
Merged
13 tasks
@felipediel
Copy link
Collaborator

felipediel commented Apr 11, 2024

Closed with #788. Thanks @bengtmartensson!

@felipediel felipediel closed this Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bengtmartensson @felipediel